Glasgow | 26-ITP-JAN | Prakash Dcosta | Sprint 3 | Implement & Rewrite Tests Coursework#1151
Open
dcostaprakash wants to merge 2 commits intoCodeYourFuture:mainfrom
Open
Glasgow | 26-ITP-JAN | Prakash Dcosta | Sprint 3 | Implement & Rewrite Tests Coursework#1151dcostaprakash wants to merge 2 commits intoCodeYourFuture:mainfrom
dcostaprakash wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
dcostaprakash
changed the title
dcostaprakash
added
the
Needs Review
cjyuan
added
Review in progress
cjyuan
reviewed
Mar 11, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Implementation looks good, and code is well formatted.
| }); | ||
|
|
||
| // When numerator is greater than the denominator | ||
| test(`should return false when numerator > denominator`, () => { |
Contributor
There was a problem hiding this comment.
-
We could use notations like
| ... |orabs(...)to indicate we are comparing their absolute values. -
What about the boundary case when abs(numerator) == abs(denominator)?
Author
There was a problem hiding this comment.
Got it. I have made the change accordingly for both the points. Thank you
Further, I have also added for not an integer which i had missed earlier. Thank you.
Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js
Show resolved
Hide resolved
cjyuan
added
Reviewed
dcostaprakash
added
Needs Review
Contributor
|
I don't see any new commits on this branch. Have you pushed your commits to GitHub? |
cjyuan
added
Reviewed
dcostaprakash
added
Needs Review
Author
|
It was done, maybe did not go through. I have done it again. Thank you |
cjyuan
reviewed
Mar 12, 2026
Comment on lines
+32
to
38
| test(`should return true when numerator < denominator`, () => { | ||
| expect(isProperFraction(2, 5)).toEqual(true); | ||
| expect(isProperFraction(1, -4)).toEqual(true); | ||
| expect(isProperFraction(-100, -214)).toEqual(true); | ||
| expect(isProperFraction(-1502, 4000)).toEqual(true); | ||
| expect(isProperFraction(18, 32)).toEqual(true); | ||
| }); |
Contributor
There was a problem hiding this comment.
Could have also used the | ... | notation in this description.
Author
There was a problem hiding this comment.
Sure. i will keep that in mind. Thank you!
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Completed all the tasks as per the coursework