Skip to content

London | 26-ITP-Jan | Carlos Abreu | Sprint 1 | Coursework#1146

Open
carlosyabreu wants to merge 19 commits intoCodeYourFuture:mainfrom
carlosyabreu:coursework/sprint-1
Open

London | 26-ITP-Jan | Carlos Abreu | Sprint 1 | Coursework#1146
carlosyabreu wants to merge 19 commits intoCodeYourFuture:mainfrom
carlosyabreu:coursework/sprint-1

Conversation

@carlosyabreu
Copy link

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

PR for Sprint 1 of Structuring and Testing Data

@carlosyabreu carlosyabreu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 3, 2026
@carlosyabreu carlosyabreu changed the title London | 26-ITP-Jan | Carlos Abreu | Sprint 1 | Structuring and Testing Data London | 26-ITP-Jan | Carlos Abreu | Sprint 1 | Coursework Mar 3, 2026
@JaypeeLan JaypeeLan added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 5, 2026
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very detailed explanations and well formatted code.

I only have some questions to challenge your understanding and some suggestions.

Comment on lines +8 to +9
/* The line 3 is increasing the variable count by 1 and assigning the result to count variable on the left hand * side.
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Operation like count = count + 1 is very common in programming, and there is a programming term describing such operation.

Can you find out what one-word programming term describes the operation on line 3?

Copy link
Author

@carlosyabreu carlosyabreu Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Evening @cjyuan

Absolutely sure.
The operator = is called the assignment operator.
On the right hand side of =, the expression count + 1 is evaluated first.
Since count currently has the value 0, count + 1 results in 1.
Then the result 1 is assigned to the variable count on the left hand side of the operator =.
At this stage the value stored in count becomes 1.
To wrap up the line 3 does is to take the current value of count, add 1 to it, and store the result back into count.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was asking for the programming term for operation like "count = count + 1" or "count++".

@cjyuan
Copy link
Contributor

cjyuan commented Mar 5, 2026

@JaypeeLan Sorry I didn't add the "Review in progress" label when I started reviewing this PR.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Mar 5, 2026
@carlosyabreu
Copy link
Author

Hi @cjyuan

After answering your queries in comment box I clicked the button 'resolution' or something similar.
That's the first time I encounter that button in PR and I'm not sure after answering I need to press the button.
After that the comment is hidden.
And 'All checks have failed' still active.
Don't know what section of the code I need to change for the bot to give 'All checks successful'.
Thanks

@carlosyabreu carlosyabreu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 5, 2026
@carlosyabreu carlosyabreu reopened this Mar 5, 2026
@carlosyabreu
Copy link
Author

Sorry @cjyuan after a few minutes the bot run showing 'All checks have passed' message.
Last message was unnecessary.
Thanks again.

@carlosyabreu carlosyabreu reopened this Mar 5, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Mar 5, 2026

All good.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants