Manchester | ITP-JAN-26 | Ofonime Edak | Sprint 3 | Coursework/sprint 3 implement and rewrite by Ofonimeedak · Pull Request #1139 · CodeYourFuture/Module-Structuring-and-Testing-Data

Ofonimeedak · 2026-03-03T01:04:16Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Angle functions
Proper fraction file
Resolved get Card Values
Write test with assertion
Rewrite test with Jest

This PR is on writing functions and carrying out unit test using JS assertion and jest

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

cjyuan · 2026-03-11T04:58:37Z

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

+});
+
 // Case 5: Reflex angles
+test(`Should return "Reflex angle" when (180>angle<360)`, () => {


The notation (180>angle<360) is not consistent with the notation used on line 23.

cjyuan · 2026-03-11T05:00:34Z

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

+});
+
 // Case 6: Invalid angles
+test(`Should return "Invalid angle" when (0 =<angle>=360)`, () => {


How about (angle <= 0 or angle >=360)?

cjyuan

Some of the code is not consistently formatted.

Have you installed the prettier VSCode extension and enabled "Format on save/paste" on VSCode, as recommended in
https://github.com/CodeYourFuture/Module-Structuring-and-Testing-Data/blob/main/readme.md
?

If you have enabled "Format on save" but it is not working, it is likely that you haven't assign a formatter for JS file. This could happen if you have zero or multiple extensions that can format .js file.

If you have installed "Prettier" extension. To assign it as the formatter of JS code, you can try:

Use "Format document" to format the JS file. Sometimes, VSCode will ask you to choose a formatter, and you can manually select "Prettier".
Edit settings.json and set Prettier as the default formatter for JS.
See: https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

cjyuan · 2026-03-15T09:51:24Z

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

+});
+
 // Case 5: Reflex angles
+test(`Should return "Reflex angle" when (360<angle>180)`, () => {


360<angle>180 -- This notation seems to suggest "angle is greater than 360 and is greater than 180". Can you revise it?

cjyuan · 2026-03-15T09:52:41Z

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

 test(`should return false when denominator is zero`, () => {
  expect(isProperFraction(1, 0)).toEqual(false);
+  expect(isProperFraction(1, -1)).toEqual(false);
+  expect(isProperFraction(10, 1)).toEqual(false);
+  expect(isProperFraction(1, 10)).toEqual(true);
+  expect(isProperFraction(-1, 0)).toEqual(false);
+  expect(isProperFraction(1e2, 1e4)).toEqual(true);
+  expect(isProperFraction(1e4, 1e0)).toEqual(false);
 });


The test description does not quite describe the tests being carried out.

cjyuan

Please note that in CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:

Reply to their feedback.
- In the responses, clarify how each piece of feedback was addressed to demonstrate that you've carefully reviewed the suggestions.
  - You may find the suggestions in this PR Guide useful.
- Your response may trigger a notification (depending on the reviewer's settings), helping ensure they’re aware of the updates you’ve made.
Replace the "Reviewed" label by a "Needs review" label (which you have done -- great!)
- Without this label, the reviewer would not know if your changes is ready to be reviewed.

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

cjyuan · 2026-03-16T22:00:23Z

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

+  expect(isProperFraction(-2, 0)).toEqual(false);
+  expect(isProperFraction(-1, 0)).toEqual(false);
  expect(isProperFraction(1, 0)).toEqual(false);
 });


These data categories and samples are not comprehensive enough. You should test also those proper and improper fraction samples you had in implement/2-is-proper-fraction.js.

Alright, I will improve the test case. Thank you very much

cjyuan

Changes look good.

cjyuan · 2026-03-20T10:42:22Z

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

+test(`should return true when denominator is > numerator `, () => {
+  expect(isProperFraction(1, 2)).toEqual(true);
+  expect(isProperFraction(1, 10000)).toEqual(true);
+
+  expect(isProperFraction(1e2, 1e3)).toEqual(true);
+  expect(isProperFraction(-1, 2)).toEqual(true);
+});
+
+test("should return false when denominator < numerator", () => {


We can use pseudo-code such as abs(...) to more accurately state the condition when the function should return true or false.

Otherwise, isProperFaction(-100, 2) would be expected to return true because 2 > -100.

Ofonimeedak added 4 commits March 2, 2026 01:23

Angle function and test casese

5209d8d

proper fraction with test cases

49570d3

resolved getCard Values with test cases

0ee00b9

Rewrite test with jest completed

d1394c1

This comment has been minimized.

Sign in to view

Ofonimeedak added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Mar 3, 2026

This comment has been minimized.

Sign in to view

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 3, 2026

This comment has been minimized.

Sign in to view

Ofonimeedak added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 3, 2026

cjyuan reviewed Mar 11, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 11, 2026

fixedproper fraction and card functions

815a1c8

Ofonimeedak requested a review from cjyuan March 14, 2026 16:34

Ofonimeedak added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 14, 2026

cjyuan reviewed Mar 15, 2026

View reviewed changes

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 15, 2026

seperated suit and refactor function

865cf09

Ofonimeedak requested a review from cjyuan March 16, 2026 09:35

Ofonimeedak added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 16, 2026

cjyuan reviewed Mar 16, 2026

View reviewed changes

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 16, 2026

refactor getCard function and add more test case

b1a1d5e

Ofonimeedak requested a review from cjyuan March 20, 2026 09:39

Ofonimeedak added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 20, 2026

cjyuan reviewed Mar 20, 2026

View reviewed changes

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 20, 2026

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 20, 2026

Uh oh!

Conversation

Ofonimeedak commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelist

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

cjyuan Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cjyuan Mar 15, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 15, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cjyuan Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

Ofonimeedak Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Ofonimeedak commented Mar 3, 2026 •

edited

Loading