Cape Town | 26-ITP-Jan | Pretty Taruvinga | Sprint 3 | Implement and rewrite test by Pretty548 · Pull Request #1130 · CodeYourFuture/Module-Structuring-and-Testing-Data

Pretty548 · 2026-03-02T15:08:47Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

This PR implements the required functions and rewrites the existing tests for Sprint 3 in the 1-implement-and-rewrite-tests directory.

All tests were updated to correctly reflect the expected behaviour, and the implementations were written to make the tests pass.

cjyuan

Function implementation looks good.

This exercise has a second part "2 Rewrite tests with Jest".

…lid cards

cjyuan

Please note that in CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:

Reply to their feedback.
- In the responses, clarify how each piece of feedback was addressed to demonstrate that you've carefully reviewed the suggestions.
  - You may find the suggestions in this PR Guide useful.
- Your response may trigger a notification (depending on the reviewer's settings), helping ensure they’re aware of the updates you’ve made.
Replace the "Reviewed" label by a "Needs review" label (which you have done -- great!)
- Without this label, the reviewer would not know if your changes is ready to be reviewed.

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

cjyuan · 2026-03-15T10:54:29Z

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

+test("should return false when numerator is negative", () => {
+  expect(isProperFraction(-1, 2)).toEqual(false);
+});
+
+test("should return true when both numerator and denominator are negative and numerator is smaller than denominator", () => {
+  expect(isProperFraction(-1, -2)).toEqual(true);
+});


The test description on line 28 is not quite accurate.

For proper fractions, the condition is, "the absolute value of denominator is larger than the absolute value of the numerator". So we can create a category for proper fractions and describe it as:
should return true when abs(numerator) < abs(denominator)

and then test all combinations of positive/negative numerator and denominator (for proper fraction) in this category.

Thank you for the feedback. I’ve updated the tests to follow the rule that a proper fraction is when abs(numerator) < abs(denominator). I grouped the proper fraction cases together and included the different positive and negative combinations. Please let me know if there is anything else I should improve.

cjyuan · 2026-03-15T11:30:47Z

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

+test(`should return "Invalid angle" when angle is not a number`, () => {
+  expect(getAngleType("not a number")).toEqual("Invalid angle");
+});


What do you expect from this function call:

getAngleType("100") or getAngleType(" +1e2") ?

Note: You don't have to include this test because the spec has already stated you can assume the parameters are always valid numbers.

Thanks for the clarification! I did not include tests for non-number inputs since the spec assumes valid numbers.

cjyuan · 2026-03-15T11:32:01Z

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

+});
+
+// Proper fractions
+test("should return true when abs(numerator) < abs(denominator)", () => {


You could also apply this notation to improper fractions.

Thanks for the suggestion! I updated the improper fraction test description to use the same abs notation and added a negative numerator/denominator case.

- Added tests for proper fractions using abs(numerator) < abs(denominator) - Added tests for improper fractions using abs(numerator) >= abs(denominator) - Covered positive, negative, and zero cases - Added test for denominator equal to zero

cjyuan · 2026-03-15T12:06:20Z

All good now. Well done.

Pretty Taruvinga added 3 commits February 22, 2026 18:22

tests were added to cover edge cases

6f5bc6a

Add i ProperFraction function with tests

0de9751

feat: implement getCardValue and cover all edge cases with tests

b4dc07e

Pretty548 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 2, 2026

Pretty548 mentioned this pull request Mar 5, 2026

Cape Town | Structuring and testing data | Pretty Taruvinga Pretty548/My-Coursework-Planner#72

Open

cjyuan reviewed Mar 11, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 11, 2026

Pretty Taruvinga added 4 commits March 12, 2026 06:19

test: add Jest tests for getAngleType function

9b97ed0

test: complete Jest tests for isProperFraction and ensure all cases pass

7a64436

test: add Jest tests for getCardValue covering number, face, and inva…

221bb71

…lid cards

fixed the change

f99a296

Pretty548 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 15, 2026

This comment has been minimized.

Sign in to view

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 15, 2026

This comment has been minimized.

Sign in to view

deleted the unwanted file

a1aff3b

Pretty548 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 15, 2026

cjyuan reviewed Mar 15, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 15, 2026

Pretty Taruvinga added 2 commits March 15, 2026 13:08

Add boundary test for angle 0 in getAngleType tests

f10a8d4

refactor tests: use absolute value rule for proper fractions

98734bf

Pretty548 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 15, 2026

cjyuan reviewed Mar 15, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 15, 2026

removed unnecessary invalid input tests

71445dc

Improve isProperFraction Jest tests

362f624

- Added tests for proper fractions using abs(numerator) < abs(denominator) - Added tests for improper fractions using abs(numerator) >= abs(denominator) - Covered positive, negative, and zero cases - Added test for denominator equal to zero

Pretty548 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 15, 2026

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 15, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Cape Town | 26-ITP-Jan | Pretty Taruvinga | Sprint 3 | Implement and rewrite test#1130

Cape Town | 26-ITP-Jan | Pretty Taruvinga | Sprint 3 | Implement and rewrite test#1130
Pretty548 wants to merge 12 commits intoCodeYourFuture:mainfrom
Pretty548:coursework/sprint-3-implement-and-rewrite

Pretty548 commented Mar 2, 2026 •

edited

Loading

Uh oh!

cjyuan left a comment •

edited

Loading

Uh oh!

This comment has been minimized.

This comment has been minimized.

cjyuan left a comment

Uh oh!

Uh oh!

cjyuan Mar 15, 2026

Uh oh!

Pretty548 Mar 15, 2026

Uh oh!

cjyuan Mar 15, 2026 •

edited

Loading

Uh oh!

Pretty548 Mar 15, 2026

Uh oh!

cjyuan Mar 15, 2026

Uh oh!

Pretty548 Mar 15, 2026

Uh oh!

cjyuan commented Mar 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Pretty548 commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Uh oh!

cjyuan left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cjyuan Mar 15, 2026

Choose a reason for hiding this comment

Uh oh!

Pretty548 Mar 15, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Pretty548 Mar 15, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 15, 2026

Choose a reason for hiding this comment

Uh oh!

Pretty548 Mar 15, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan commented Mar 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Pretty548 commented Mar 2, 2026 •

edited

Loading

cjyuan left a comment •

edited

Loading

cjyuan Mar 15, 2026 •

edited

Loading