generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 336
London | 26-ITP-Jan | Boualem Larbi Djebbour | sprint 2 | Coursework #1123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
djebsoft
wants to merge
28
commits into
CodeYourFuture:main
Choose a base branch
from
djebsoft:coursework/sprint-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
eac1a1b
declaraing the variable 'result' in capitalise function
djebsoft 0a7da43
Fix duplicate variable declaration and assigning in convertToPercenta…
djebsoft 45b6a43
Fix square function parameter
djebsoft b594c90
Fix multiply function to return and log result
djebsoft 7fbd07f
Fix sum function to return correct value
djebsoft 54e11ce
Fix getLastDigit function to return correct last digit
djebsoft 97bdb37
Fixing typo
djebsoft 9dfa312
Implement BMI calculation in calculateBMI function
djebsoft 5fb3b93
Update comments with answers in time-format.js
djebsoft b745976
turn the to-pounds program into a reusable block of code
djebsoft 6dcd3ad
Implement upperSnakeCase function
djebsoft 98c6c44
formatting using prettier
djebsoft 49c0e77
formatting using prettier
djebsoft f46495a
formatting using prettier
djebsoft 3a4cd9c
formatting using prettier
djebsoft 0187c34
formatting using prettier
djebsoft d824908
formatting using prettier
djebsoft e3e2a6e
formatting using prettier
djebsoft d979e47
formatting using prettier
djebsoft 074eddb
formatting using prettier
djebsoft 614b5fc
formatting using prettier
djebsoft 4e87db6
formatting using prettier
djebsoft ecbbbef
formatting using prettier
djebsoft 69ae220
formatting using prettier
djebsoft 0f84719
deleted the console.log statement from the function and added a retur…
djebsoft 3adc57d
fixed the statement of the value returned & converted the output to a…
djebsoft 1393ad5
fixed the function to return the coverted value
djebsoft 132b50e
Fix return statement in calculateBMI function
djebsoft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,19 @@ | ||
| // Predict and explain first... | ||
|
|
||
| // =============> write your prediction here | ||
| // =============> the function when called will throw an error | ||
|
|
||
| function multiply(a, b) { | ||
| console.log(a * b); | ||
| } | ||
|
|
||
| console.log(`The result of multiplying 10 and 32 is ${multiply(10, 32)}`); | ||
|
|
||
| // =============> write your explanation here | ||
|
|
||
| // =============> the function multiply has no return statement | ||
| // when we call the function multiply(10, 32) it will throw this message: The result of multiplying 10 and 32 is undefined | ||
| // Finally, correct the code to fix the problem | ||
| // =============> write your new code here | ||
| // =============> | ||
| function multiply(a, b) { | ||
| return a * b; // we change the console.log statement with the return statement | ||
| } | ||
|
|
||
| console.log(`The result of multiplying 10 and 32 is ${multiply(10, 32)}`); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about this version:
wsUpperSnakeCase? (No change needed)Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it could be shortened and embeded in the previous line