Birmingham | 26-ITP-Jan | Arun Kumar Akilan | Sprint 2 | Structuring-and-Testing-Data Coursework/Sprint2#1117
Open
arunkumarakilan wants to merge 7 commits intoCodeYourFuture:mainfrom
Open
Conversation
This comment has been minimized.
This comment has been minimized.
arunkumarakilan
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
arunkumarakilan
force-pushed
the
coursework/sprint-2
branch
from
5cecbee to
ab3d116
Compare
arunkumarakilan
added
the
Needs Review
tee4tao
added
Review in progress
tee4tao
suggested changes
Mar 1, 2026
| const hours = Number(time.slice(0, 2)); | ||
| if (hours > 12) { | ||
| return `${hours - 12}:00 pm`; | ||
| time = hours - 12; |
There was a problem hiding this comment.
In your new logic, you assigned the calculated number to time. While JavaScript allows this, time was originally our input string (e.g., '19:00'). Reassigning parameters to completely different data types can sometimes lead to confusing bugs later on. Can you think of a better way to store your calculated hours - 12 without overwriting the time parameter? Perhaps a new variable name?
There was a problem hiding this comment.
@arunkumarakilan can you please reply to the reviewer? This has been waiting for 4 days now and you should reply asap.
tee4tao
added
Reviewed
arunkumarakilan
added
the
Needs Review
tee4tao
added
Review in progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
This PR contains my completed Sprint 2 coursework for the Structuring and Testing Data module.
Summary of changes:
padStartAll tasks have been completed and verified to work correctly.
Questions
No questions at this time.