Sheffield | 26-Jan-ITP| Mona-Eltantawy | Sprint 1 | Coursework/ Sprint1#1109
Open
Mona-Eltantawy wants to merge 15 commits intoCodeYourFuture:mainfrom
Open
Sheffield | 26-Jan-ITP| Mona-Eltantawy | Sprint 1 | Coursework/ Sprint1#1109Mona-Eltantawy wants to merge 15 commits intoCodeYourFuture:mainfrom
Mona-Eltantawy wants to merge 15 commits intoCodeYourFuture:mainfrom
Conversation
…oing. for File 1 in exercises.
…the const varible place to be before the console function line.
…need to changw the card number to string if we want to use .slice( ) function.
…variable name shoudn't start with a number.
Mona-Eltantawy
added
the
Needs Review
cjyuan
reviewed
Feb 28, 2026
Comment on lines
+15
to
+19
| there are 4 function calls in this File, they are in the following lines: | ||
| line 1: carPrice.replaceAll(",", "") | ||
| line 2: priceAfterOneYear.replaceAll(",", "") | ||
| line 3: Number(carPrice.replaceAll(",", "")) | ||
| line 4: Number(priceAfterOneYear.replaceAll(",", "")) |
Contributor
There was a problem hiding this comment.
There are more than 4 function calls.
Author
There was a problem hiding this comment.
because it required 4 calls I just mentioned those 4.
do I need to add more?
Contributor
There was a problem hiding this comment.
You can just list the remaining function(s) here. No need to update the file.
cjyuan
added
Reviewed
…lt variable name.
Mona-Eltantawy
added
the
Needs Review
Contributor
|
Changes look good. |
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist