-
-
Notifications
You must be signed in to change notification settings - Fork 337
London | 26-ITP-January | Karla Grajales | Sprint 3 | Practice TDD #1079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Grajales-K
wants to merge
12
commits into
CodeYourFuture:main
Choose a base branch
from
Grajales-K:coursework/sprint-3-practice-tdd
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
19452c4
test: add cases for no occurrences and case sensitivity in countChar …
Grajales-K b7cdfee
feat: implement character counting function in count.js
Grajales-K a355524
test: add TDD cases for the function get-ordinal-numbers to add suffix
Grajales-K 2e25623
feat: add ordinal suffix handling including special cases for 11, 12,…
Grajales-K b498ab0
test: add cases for count of 0 and negative count in repeatStr function
Grajales-K 11a1b98
feat: enhance repeatStr function to handle negative counts and improv…
Grajales-K 4c0130e
refactor: simplify repeatStr function by removing redundant check for…
Grajales-K b548ddb
feat: update negative count error message in repeatStr
Grajales-K b00a6cb
test: add cases for non-alphabet characters in countChar function
Grajales-K e04af18
refactor: simplify repeatStr function using built-in string method
Grajales-K 49a3b76
refactor: remove manual try/catch because Jest covers this case
Grajales-K 0af1ee0
refactor: streamline repeatStr function by removing commented code an…
Grajales-K File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,15 @@ | ||
| function countChar(stringOfCharacters, findCharacter) { | ||
| return 5 | ||
|
|
||
| let count = 0; | ||
|
|
||
| for (i = 0; i < stringOfCharacters.length; i++) { | ||
| if (stringOfCharacters[i] === findCharacter) { | ||
| count += 1; | ||
| } | ||
| } | ||
|
|
||
| return count; | ||
| } | ||
|
|
||
| module.exports = countChar; | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,19 @@ | ||
| function getOrdinalNumber(num) { | ||
| return "1st"; | ||
|
|
||
| const lastTwoDigits = num % 100; | ||
| const lastDigit = num % 10 | ||
|
|
||
|
|
||
| if (lastTwoDigits === 11 || lastTwoDigits === 12 || lastTwoDigits === 13) { | ||
| return num + "th"; | ||
| } | ||
|
|
||
|
|
||
| if(lastDigit === 1) return num + "st"; | ||
| if(lastDigit === 2) return num + "nd"; | ||
| if(lastDigit === 3) return num + "rd"; | ||
|
|
||
| return num + "th" | ||
| } | ||
|
|
||
| module.exports = getOrdinalNumber; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,46 @@ | ||
| function repeatStr() { | ||
| return "hellohellohello"; | ||
| // function repeatStr(str, count) { | ||
| // if (count < 0) { | ||
| // throw new Error("count cannot be negative"); | ||
| // } | ||
|
|
||
| // let result = ""; | ||
| // for (let i = 0; i < count; i++) { | ||
| // result = result + str; | ||
| // } | ||
| // return result; | ||
| // } | ||
|
|
||
| // The repeat() method of String values constructs and returns | ||
| // a new string which contains the specified number of copies | ||
| // of this string, concatenated together. | ||
| //repeatStr("abc", 3); // "abcabcabc" | ||
|
|
||
| //refactored function using built-in method | ||
|
Grajales-K marked this conversation as resolved.
Outdated
|
||
| function repeatStr(str, count) { | ||
| if (count < 0) { | ||
| throw new Error("count cannot be negative"); | ||
| } | ||
| return str.repeat(count); | ||
| } | ||
|
|
||
|
|
||
| module.exports = repeatStr; | ||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
| // // Case: Manual inspection of the Error object | ||
| // // We use try/catch to log the error message to the console | ||
| // // to verify it's working as expected without breaking the test suite. | ||
| // test("Should log the specific error message to the console", () => { | ||
| // try { | ||
| // repeatStr("hi", -3); | ||
| // } catch (error) { | ||
| // console.log("Verified Error Message ->", error.message); | ||
|
|
||
| // // Check if the message is exactly what we defined | ||
| // expect(error.message).toBe("count cannot be negative"); | ||
| // } | ||
|
|
||
| // }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.