Manchester | 26-ITP-Jan | Mehroz Munir | Sprint 2 | Coursework#1077
Manchester | 26-ITP-Jan | Mehroz Munir | Sprint 2 | Coursework#1077MehrozMunir wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
MehrozMunir
added
📅 Sprint 2
| @@ -1,5 +1,5 @@ | |||
| // Predict and explain first... | |||
| // =============> write your prediction here | |||
| // I am not able to predict any error, everything seems fine to me. | |||
There was a problem hiding this comment.
There's an error in the function. Have a look again and write the fix in the commented out code below on line 16
| // =============> write your explanation here | ||
| // =============> Yes, the error is because the identifier decimalNumber has already been declared. | ||
|
|
||
| // Finally, correct the code to fix the problem |
There was a problem hiding this comment.
Finally, you need to correct the code to fix the problem. Correct the code below. Code seems to be commented out
Sprint-2/2-mandatory-debug/2.js
Outdated
|
|
||
| // Finally, correct the code to fix the problem | ||
| // =============> write your new code here | ||
| /* |
| //The function is returning undefined | ||
|
|
||
| // Finally, correct the code to fix the problem | ||
| // =============> write your new code here |
There was a problem hiding this comment.
The code is commented out. You need to uncomment this part of the code, which is your fix for the error above
Sprint-2/2-mandatory-debug/0.js
Outdated
|
|
||
| // Finally, correct the code to fix the problem | ||
| // =============> write your new code here | ||
| /* |
| // Finally, correct the code to fix the problem | ||
|
|
||
| // =============> write your new code here | ||
|
|
There was a problem hiding this comment.
Hi @netEmmanuel
Thank you for your feedback.
I wrote the correct code in these files in comments to avoid the confusion of the same name function in the code. Moreover, it was not clear from the instructions in some of the files if we even supposed to write the correct code like in 1-key-errors/0.js file. However, I have commented out the correct code in all these files.
I have pushed my latest code. You may review please.
netEmmanuel
added
Review in progress
MehrozMunir
added
the
Needs Review
|
@netEmmanuel Could you please review my code now? I have made the changes you asked me for. Thanks. |
2 participants
Learners, PR Template
Self checklist
Changelist
This pull request is to get review for changes made in the sprint 2 folder. I have tried my best to follow the instructiosn provided in each js file of this folder to explain the code, write the code or fix errors.