London | 26-Jan-ITP | Shuheda Begum | Sprint 3 | Implement and Rewrite Test#1071
Open
codebyshay wants to merge 1 commit intoCodeYourFuture:mainfrom
Open
London | 26-Jan-ITP | Shuheda Begum | Sprint 3 | Implement and Rewrite Test#1071codebyshay wants to merge 1 commit intoCodeYourFuture:mainfrom
codebyshay wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
codebyshay
added
📅 Sprint 3
codebyshay
changed the title
A-O-Emmanuel
added
Review in progress
| // Card must be at least 2 characters (e.g., "A♠") | ||
| if (typeof card !== "string" || card.length < 2) { | ||
| throw new Error("Invalid card"); | ||
| } |
| throw new Error("Invalid card"); | ||
| } | ||
|
|
||
| // Suit is always the last character |
There was a problem hiding this comment.
Your comments are also good, but for one line code, it might not be necessary, but still it's good practice👍
Author
There was a problem hiding this comment.
Thank you. I did extra notes so I can refer back to it and understand what I did.
A-O-Emmanuel
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed all task required for Sprint 3 - Implement and rewrite test.
Questions
No questions.