London | 26-Jan-ITP | Shuheda Begum | Sprint 2 | Coursework by codebyshay · Pull Request #1070 · CodeYourFuture/Module-Structuring-and-Testing-Data

codebyshay · 2026-02-25T23:36:10Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Completed all task required for Sprint 2

Questions

No questions.

I added the description the term increment

Restored 3.js to original text and made a prediction about the use of slice

I updated the code and ran it to test. The code worked and logged the last for digits of the card, 4213.

…ng-and-Testing-Data into Sprint-2

Theoreoluwa · 2026-03-07T14:59:28Z

Sprint-2/1-key-errors/0.js

-  return str;
+  if (!str) return str; // handles empty string
+  return str[0].toUpperCase() + str.slice(1);
 }


Good thinking to consider handling the empty string error.

Thank you :)

Theoreoluwa · 2026-03-07T15:10:50Z

Sprint-2/2-mandatory-debug/1.js

+// Write your explanation here
+// When JavaScript sees the 'return' statement, it immediately stopd the function. 


Yes, this is correct. You can read more on the exact operation; it is called in JavaScript. I man the termination of the function when the return keyword appears on its own line

Ok, will do. Thank you.

Theoreoluwa · 2026-03-07T15:25:45Z

Sprint-2/3-mandatory-implement/3-to-pounds.js

+function toPounds(penceString) {
+  const penceStringWithoutTrailingP = penceString.substring(
+    0,
+    penceString.length - 1
+  );
+
+  const paddedPenceNumberString = penceStringWithoutTrailingP.padStart(3, "0");
+
+  const pounds = paddedPenceNumberString.substring(
+    0,
+    paddedPenceNumberString.length - 2
+  );
+
+  const pence = paddedPenceNumberString
+    .substring(paddedPenceNumberString.length - 2)
+    .padEnd(2, "0");
+
+  return `£${pounds}.${pence}`;
+}


I understand you used the context of the code in the previous sprint, but this code could have been written in a much cleaner way by using some other functions to perform some conversions to the string. You can have a read on that as you progress.

Theoreoluwa · 2026-03-07T15:34:55Z

Sprint-2/5-stretch-extend/format-time.js

-  `current output: ${currentOutput2}, target output: ${targetOutput2}`
-);
+//testing the function with various inputs.
+console.log(formatAs12HourClock("08:00")); // 08:00 am


You need to write tests for various time formats. Unit tests, not console.log statements.

Hi, I will type the answer here. there seems to be a conflict with my work and when I'm saving the work and adding a commit, its not being pushed. I fear this may be due to an issue I had with the branch previously, which led me to starting over again. I had the same issue with Sprint One. I don't have the opportunity to start over again, as all work had to be submitted by yesterday, I will save my answers here. I hope that ok.

import { formatAs12HourClock } from "./formatAs12HourClock";

describe("formatAs12HourClock", () => {
test("formats morning time correctly", () => {
expect(formatAs12HourClock("08:00")).toBe("08:00 am");
});

test("formats evening time correctly", () => {
expect(formatAs12HourClock("23:00")).toBe("11:00 pm");
});

test("formats midnight correctly", () => {
expect(formatAs12HourClock("00:30")).toBe("12:30 am");
});

test("formats noon correctly", () => {
expect(formatAs12HourClock("12:15")).toBe("12:15 pm");
});

test("formats afternoon time correctly", () => {
expect(formatAs12HourClock("13:45")).toBe("01:45 pm");
});

test("formats late morning correctly", () => {
expect(formatAs12HourClock("11:59")).toBe("11:59 am");
});

test("formats exactly noon", () => {
expect(formatAs12HourClock("12:00")).toBe("12:00 pm");
});
});

Theoreoluwa · 2026-03-07T15:35:27Z

Sprint-2/5-stretch-extend/format-time.js

+  let [hours, minutes] = time.split(":");
+  hours = Number(hours);
+  let period = "am";
+
+  if (hours === 0) {
+    hours = 12; // midnight
+  } else if (hours === 12) {
+    period = "pm"; // noon
+  } else if (hours > 12) {
+    hours -= 12;
+    period = "pm";


Good solution to the bugs present in the code.

Theoreoluwa

Great job, Shuheda. Please look at my comments for better improvement. Keep going!

codebyshay · 2026-03-09T11:15:12Z

Thank you. I am having trouble saving and committing the changes, so have posted the answers to any questions on here. I hope that ok. Thank you.

Theoreoluwa · 2026-03-11T10:24:46Z

I’ll look through your comments. Your pr contains a conflict. That’s why it’s giving you issues when you want to commit and raise another pr.

codebyshay · 2026-03-11T13:03:07Z

Yes, I'm not sure how to resolve it 🥺

Theoreoluwa · 2026-03-11T17:39:10Z

Looking at your answers, the test script you put in the comments were written using the Jest test suite. The code within the task gives you a little template on how to write tests as required for the function within the code. You should apply that as it helps solidify your idea of feature testing at this level. Rather than using a test suite for it.
Also, please try to look in your code and resolve the merge conflict. Mainly look at the task for the test code.

I'll be marking your work as done as the test task isn't entirely mandatory.

codebyshay · 2026-03-11T19:45:45Z

Thank you so much. I will definitely look into what you said. Hopefully this weekend at class I can get some help with the conflict too.

Theoreoluwa

Good job, keep going.

codebyshay added 2 commits February 25, 2026 23:16

Sprint one task complete

91f41d8

Completed all task required for sprint 2

be5c268

codebyshay added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 25, 2026

codebyshay mentioned this pull request Feb 26, 2026

26-ITP-JAN | Structuring and testing data | Shuheda Begum codebyshay/My-Coursework-Planner#44

Open

codebyshay added 6 commits March 5, 2026 11:34

Description of increment

211f3eb

I added the description the term increment

3.js restored

17b2307

Restored 3.js to original text and made a prediction about the use of slice

Update 3.js

8578bb7

I updated the code and ran it to test. The code worked and logged the last for digits of the card, 4213.

Update 3.js

b20e658

testing commit

70c46af

Merge branch 'main' of https://github.com/codebyshay/Module-Structuri…

7b1d8e1

…ng-and-Testing-Data into Sprint-2

Theoreoluwa reviewed Mar 7, 2026

View reviewed changes

Theoreoluwa added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 7, 2026

Theoreoluwa reviewed Mar 7, 2026

View reviewed changes

Theoreoluwa added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Mar 7, 2026

Added terminating the function

c55aab8

codebyshay added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 9, 2026

Theoreoluwa added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 11, 2026

Added jest tests

8e61326

Theoreoluwa reviewed Mar 15, 2026

View reviewed changes

		// Write your explanation here
		// When JavaScript sees the 'return' statement, it immediately stopd the function.

Uh oh!

Conversation

codebyshay commented Feb 25, 2026

Learners, PR Template

Changelist

Questions

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Theoreoluwa left a comment

Choose a reason for hiding this comment

Uh oh!

codebyshay commented Mar 9, 2026

Uh oh!

Theoreoluwa commented Mar 11, 2026

Uh oh!

codebyshay commented Mar 11, 2026

Uh oh!

Theoreoluwa commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codebyshay commented Mar 11, 2026

Uh oh!

Theoreoluwa left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Theoreoluwa commented Mar 11, 2026 •

edited

Loading