London | 26-ITP-Jan | Maryanne Mosonik | Sprint 3 | Practice-TDD

[Maryanne-K]

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

This PR contains the Practise-TDD section of Sprint 3.

I agree to follow the code of conduct for this organisation.

[cjyuan]

Can your implementation pass this test?

[Maryanne-K]

Yes it would because it is specifically checking for a negative count, which is an error.

@cjyuan Kindly check implemented corrections. Thank you for your help.

[cjyuan]

Did you run the test script to find out if your function can pass the test or if the test is prepared correctly?

[Maryanne-K]

Apologies, just checked, it fails, forgot to add the word integer as the expected substring and received messages were different.

[cjyuan]

repeat-str.js or repeat-str.test.js still have an issue to be addressed. Other changes look good.

You should also add the "Needs Review" label when the PR is ready to be re-reviewed.

[cjyuan]

Changes to the code look good.

But your last commit also committed a change to package.json -- a file that the Validation bot does not expect (because it is not a file inside the Sprint-3/2-practice-tdd folder).

Can you revert (undo) the change to package.json? (Otherwise the bot will not allow you to use "Needs Review" label)

---

One way to revert changes to a file is via the git restore command.

First, locate a commit before the file was modified. It could be the first commit you made, assuming the branch started in a clean state.

Next, record the first 7 characters of the commit SHA.

Suppose the file is path/to/file, and you want to restore the file to its state before the commit with SHA 1234567.
The command is:

git restore --source=1234567^ path/to/file

After the file is restored, make a commit and push the changes to GitHub.

[Maryanne-K]

Changes to the code look good.

But your last commit also committed a change to package.json -- a file that the Validation bot does not expect (because it is not a file inside the Sprint-3/2-practice-tdd folder).

Can you revert (undo) the change to package.json? (Otherwise the bot will not allow you to use "Needs Review" label)

One way to revert changes to a file is via the git restore command.

First, locate a commit before the file was modified. It could be the first commit you made, assuming the branch started in a clean state.

Next, record the first 7 characters of the commit SHA.

Suppose the file is path/to/file, and you want to restore the file to its state before the commit with SHA 1234567. The command is:

git restore --source=1234567^ path/to/file

After the file is restored, make a commit and push the changes to GitHub.

Just saw this, thank you CJ. I deleted my last commit, force pushed and made the changes again.

[cjyuan]

All good now! Well done.