London | 26-ITP-January | Johnny Vargas | Sprint 3 | 1-implement-and-rewrite-tests #1062
Open
JohnnyBoyV wants to merge 10 commits intoCodeYourFuture:mainfrom
Open
London | 26-ITP-January | Johnny Vargas | Sprint 3 | 1-implement-and-rewrite-tests #1062JohnnyBoyV wants to merge 10 commits intoCodeYourFuture:mainfrom
JohnnyBoyV wants to merge 10 commits intoCodeYourFuture:mainfrom
Conversation
JohnnyBoyV
added
the
Needs Review
cjyuan
reviewed
Mar 6, 2026
Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js
Outdated
Show resolved
Hide resolved
Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js
Outdated
Show resolved
Hide resolved
Comment on lines
+30
to
+32
| expect(() => getCardValue("1♠")).toThrow("Invalid card"); | ||
| expect(() => getCardValue("A-Z")).toThrow("Invalid card"); | ||
| expect(() => getCardValue("Joker")).toThrow("Invalid card"); |
Contributor
There was a problem hiding this comment.
Could consider test also
- An empty string
- A string with a valid rank but invalid suit
cjyuan
added
Reviewed
JohnnyBoyV
added
Needs Review
Contributor
|
Changes are good. Well done. |
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I implemented the require code and also rewrote tests using jest.