Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sprint-3/3-dead-code/README.md
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were not meant to delete the file with the instructions. Can we bring it back?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readme has returned

Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ Here are two example of code that has not been built efficiently. Both files hav

1. Work through each `exercise` file inside this directory.
2. Delete the dead code.
3. Commit your changes and make a PR when done.
3. Commit your changes and make a PR when done.
4 changes: 1 addition & 3 deletions Sprint-3/3-dead-code/exercise-1.js
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting out and removing are not the same thing; knowing that, can you tidy these files up?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed code lines

Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,11 @@ let testName = "Jerry";
const greeting = "hello";

function sayHello(greeting, name) {
const greetingStr = greeting + ", " + name + "!";
return `${greeting}, ${name}!`;
console.log(greetingStr);
}

testName = "Aman";
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will either result in a variable in the global scope or throw an error. Can you find a way to fix it?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adjusted code


const greetingMessage = sayHello(greeting, testName);
const greetingMessage = sayHello(greeting, testName);

console.log(greetingMessage); // 'hello, Aman!'
11 changes: 7 additions & 4 deletions Sprint-3/3-dead-code/exercise-2.js
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same note re; comment vs deletion

Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
// Remove the unused code that does not contribute to the final console log
// The countAndCapitalisePets function should continue to work for any reasonable input it's given, and you shouldn't modify the pets variable.


const pets = ["parrot", "hamster", "horse", "dog", "hamster", "cat", "hamster"];
const capitalisedPets = pets.map((pet) => pet.toUpperCase());

const petsStartingWithH = pets.filter((pet) => pet[0] === "h");

function logPets(petsArr) {
petsArr.forEach((pet) => console.log(pet));
}



function countAndCapitalisePets(petsArr) {
const petCount = {};
Expand All @@ -23,6 +23,9 @@ function countAndCapitalisePets(petsArr) {
return petCount;
}


const countedPetsStartingWithH = countAndCapitalisePets(petsStartingWithH);


console.log(countedPetsStartingWithH); // { 'HAMSTER': 3, 'HORSE': 1 } <- Final console log