Skip to content

London | 26-Jan-ITP | Raihan Sharif | Sprint 3 | Implement and rewrite with jest#1054

Open
RaihanSharif wants to merge 5 commits intoCodeYourFuture:mainfrom
RaihanSharif:sprint-3-implement-and-rewrite
Open

London | 26-Jan-ITP | Raihan Sharif | Sprint 3 | Implement and rewrite with jest#1054
RaihanSharif wants to merge 5 commits intoCodeYourFuture:mainfrom
RaihanSharif:sprint-3-implement-and-rewrite

Conversation

@RaihanSharif
Copy link

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Implemented and tested all functions

@RaihanSharif RaihanSharif added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 25, 2026
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 6, 2026
@RaihanSharif RaihanSharif force-pushed the sprint-3-implement-and-rewrite branch 3 times, most recently from ab117d3 to b737af3 Compare March 6, 2026 23:56
@RaihanSharif RaihanSharif added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 7, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Mar 7, 2026

Changes look good.

Please note that in CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:

  • Reply to their feedback.
    • In the responses, clarify how each piece of feedback was addressed to demonstrate that you've carefully reviewed the suggestions.
      • You may find the suggestions in this PR Guide useful.
    • Your response may trigger a notification (depending on the reviewer's settings), helping ensure they’re aware of the updates you’ve made.
  • Replace the "Reviewed" label by a "Needs review" label (which you have done -- great!)
    • Without this label, the reviewer would not know if your changes is ready to be reviewed.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 7, 2026
@RaihanSharif
Copy link
Author

I have read the PR guide, and will follow it going forward.

I'll also edit my other PRs to be fully in line with the guide.

Thank you for your patience.

I appreciate your feedback; it is important for me to break these sloppy habits 🙂.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants