London | 26-ITP-January | Damian Dunkley | Sprint 3 | Coursework/sprint3/2-practice-tdd#1053
Open
DamianDL wants to merge 7 commits intoCodeYourFuture:mainfrom
Open
London | 26-ITP-January | Damian Dunkley | Sprint 3 | Coursework/sprint3/2-practice-tdd#1053DamianDL wants to merge 7 commits intoCodeYourFuture:mainfrom
DamianDL wants to merge 7 commits intoCodeYourFuture:mainfrom
Conversation
DamianDL
added
📅 Sprint 3
cjyuan
reviewed
Mar 6, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Your code is correct. I just have a few suggestions.
Comment on lines
+5
to
+8
| let result = ""; | ||
| for (let i = 0; i < count; i++) { | ||
| result += str; | ||
| } |
Contributor
There was a problem hiding this comment.
Note: String has a built-in method for repeating itself.
cjyuan
added
Reviewed
…nsitive and non-alphanumerics, as per feedback.
DamianDL
added
Needs Review
cjyuan
reviewed
Mar 6, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Changes look good, but I am not sure if you have pushed all changes to GitHub.
cjyuan
added
Reviewed
…ing the same expression multiple times
DamianDL
added
Needs Review
cjyuan
reviewed
Mar 6, 2026
Comment on lines
+3
to
+7
| `` | ||
| const lastTwoDigits = num % 100; | ||
| if (lastTwoDigits >= 11 && lastTwoDigits<= 13) | ||
| return num + "th"; | ||
|
|
Contributor
There was a problem hiding this comment.
Something weird on line 3 and indentation is off.
Have you installed prettier VSCode extension and enable formatting on save/paste on VSCode
as recommended in
https://github.com/CodeYourFuture/Module-Structuring-and-Testing-Data/blob/main/readme.md
?
Author
There was a problem hiding this comment.
Prettier installed and changes updated on save. changes to use last digit for 1/2 &3 updated.
cjyuan
added
Reviewed
DamianDL
added
Needs Review
Contributor
|
Changes look good. Well done. |
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Updates to;
count.test.js
repeat-str.test.js
get-ordinal-number.test.js
Questions