generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 336
London | 26-ITP-Jan | Kris Oldrini | Sprint 3 | Practice TDD #1046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
XiaoQuark
wants to merge
9
commits into
CodeYourFuture:main
Choose a base branch
from
XiaoQuark:practice-tdd/sprint-3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1cc87c5
complete 2-practice-tdd/count task
XiaoQuark a0605d6
refactor 2-practice-tdd/count task
XiaoQuark 13e7832
write tests for 2-practice-tdd/get-ordinal-number
XiaoQuark f07827f
write function getOrdinalNumber()
XiaoQuark d80460d
refactor tests for clearer cases
XiaoQuark 5282cbf
write tests for repeat-str task
XiaoQuark d09a54e
write function repeat-str()
XiaoQuark b9967fa
refactor function repeatStr()
XiaoQuark 7f98537
fix: create 2 more tests for special cases and change the function so…
XiaoQuark File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,9 @@ | ||
| function countChar(stringOfCharacters, findCharacter) { | ||
| return 5 | ||
| const metaCharRegex = /[.^$*+?{}\[\]\\|()]/g; | ||
| const safeChar = findCharacter.replace(metaCharRegex, `\\$&`); | ||
| const charRegex = new RegExp(safeChar, "g"); | ||
| const charArr = [...stringOfCharacters.matchAll(charRegex)]; | ||
| return charArr.length; | ||
| } | ||
|
|
||
| module.exports = countChar; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,12 @@ | ||
| function getOrdinalNumber(num) { | ||
| return "1st"; | ||
| const lastTwoDigits = num % 100; | ||
| if (lastTwoDigits === 11 || lastTwoDigits === 12 || lastTwoDigits === 13) | ||
| return `${num}th`; | ||
| const lastDigit = num % 10; | ||
| if (lastDigit === 1) return `${num}st`; | ||
| if (lastDigit === 2) return `${num}nd`; | ||
| if (lastDigit === 3) return `${num}rd`; | ||
| return `${num}th`; | ||
| } | ||
|
|
||
| module.exports = getOrdinalNumber; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| function repeatStr() { | ||
| return "hellohellohello"; | ||
| function repeatStr(str, count) { | ||
| if (count < 0) throw new Error("Invalid format: count cannot be negative"); | ||
| return str.repeat(count); | ||
| } | ||
|
|
||
| module.exports = repeatStr; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could consider testing more samples.
Could consider test these cases:
charis a certain non-alphabet character that has special meaning in regex.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you CJ, I reviewed your comment, and I think I'm now covering all the cases you mentioned.
This was actually really fun to work on. I've been learning a lot about working with regex.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work ok now.
I am glad you learned something more about regex.
It is ok to use this approach in this course but I wouldn't recommend it in practice for such a task.
Can you find out (maybe from AI) the pros and cons using this approach to count characters?