London | JAN-2026 ITP | Asha Ahmed | Sprint 3 | practice TDD coursework #1039
Open
ashaahmed7 wants to merge 6 commits intoCodeYourFuture:mainfrom
Open
London | JAN-2026 ITP | Asha Ahmed | Sprint 3 | practice TDD coursework #1039ashaahmed7 wants to merge 6 commits intoCodeYourFuture:mainfrom
ashaahmed7 wants to merge 6 commits intoCodeYourFuture:mainfrom
Conversation
… times with error handling for negative counts
ashaahmed7
added
the
Needs Review
ashaahmed7
changed the title
cjyuan
reviewed
Mar 6, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Both implementation and tests look good.
Comment on lines
+6
to
+19
| let ordinalResult = ""; | ||
| switch (lastDigit) { | ||
| case "1": | ||
| ordinalResult = `${num}st`; | ||
| break; | ||
| case "2": | ||
| ordinalResult = `${num}nd`; | ||
| break; | ||
| case "3": | ||
| ordinalResult = `${num}rd`; | ||
| break; | ||
| default: | ||
| ordinalResult = `${num}th`; | ||
| } |
Contributor
There was a problem hiding this comment.
Why not return the value directly, like what you did on line 3?
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Implemented countChar using TDD approach.
Implemented getOrdinalNumber with correct handling of 11, 12, 13 special cases.
Implemented repeatStr including edge cases (0 count and negative count error).
Added Jest tests to cover normal cases, edge cases, and error scenarios.
Questions
n/a