London | 26-ITP-January | Khaliun Baatarkhuu | Sprint 1 | Coursework. #1030
Open
khaliun-dev wants to merge 14 commits intoCodeYourFuture:mainfrom
Open
London | 26-ITP-January | Khaliun Baatarkhuu | Sprint 1 | Coursework. #1030khaliun-dev wants to merge 14 commits intoCodeYourFuture:mainfrom
khaliun-dev wants to merge 14 commits intoCodeYourFuture:mainfrom
Conversation
Corrected the increment operation for the count variable.
…d assigned them as "CKJ".
…clared first then used.
Changed cardNumber to a string before slicing to get last 4 digits.
Updated variable names to follow JavaScript naming conventions.
Fixed syntax error by adding a missing comma in replaceAll function calls.
…lize the reasoning behind the code.
Clarify the effects and return values of alert and prompt functions.
Added explanations about the console object and its methods.
khaliun-dev
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
khaliun-dev
changed the title
khaliun-dev
added
the
Needs Review
cjyuan
reviewed
Mar 4, 2026
Comment on lines
+26
to
+27
| 3. If I enter my name undefined appears, same if i press the cancel button. Fixed this by adding myName at the end. | ||
| Now the value when i enter my name shows "my name", if i press cancel it shows "null". |
Contributor
There was a problem hiding this comment.
What you observed were the output produced by console.log()
When a value is output on the console, it is converted to a string first. As such, just by looking at the output, we could not tell the actual type of the value being returned by the function. For examples, in both of the following actions, console.log() would output "null" on the screen.
- A user entered "null" in the dialog box and then clicked "OK.
- A user entered nothing in the dialog box and then clicked "Cancel"
Can you look up the Window.prompt() function at MDN Web Docs and find out what this function returns?
Author
There was a problem hiding this comment.
Window.prompt() returns a string containing the text entered by the user, or null.
Author
There was a problem hiding this comment.
@cjyuan Good morning,
Thank you for your hard work reviewing everything and your feedback. I think, i have completed and understood all the points you have raised.
Could you have another look, please?
Khaliun
cjyuan
added
Reviewed
khaliun-dev
added
the
Needs Review
Contributor
|
All responses are spot on. Well done. |
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Debugged errors, explained some of the answers i have provided with reasoning, and implemented functions.
Questions
None at the moment.