London | Jan2026 | Ihor Taradaiko | Sprint 3 | Sprint-3-implement-and-rewrite#1028
Open
ihortar wants to merge 13 commits intoCodeYourFuture:mainfrom
Open
London | Jan2026 | Ihor Taradaiko | Sprint 3 | Sprint-3-implement-and-rewrite#1028ihortar wants to merge 13 commits intoCodeYourFuture:mainfrom
ihortar wants to merge 13 commits intoCodeYourFuture:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
ihortar
added
the
Needs Review
cjyuan
reviewed
Mar 3, 2026
Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js
Outdated
Show resolved
Hide resolved
Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js
Outdated
Show resolved
Hide resolved
Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js
Outdated
Show resolved
Hide resolved
cjyuan
added
Reviewed
Contributor
|
Can you format your PR description to make it look like this:
ChangelistCompleted the following exercises:
|
ihortar
added
the
Needs Review
Contributor
|
Your PR Description does not yet look like what is shown in this comment: #1028 (comment) |
Author
Done |
cjyuan
removed
the
Needs Review
ihortar
added
the
Needs Review
cjyuan
reviewed
Mar 4, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Changes look good. Well done.
Comment on lines
+58
to
+60
| expect(() => getCardValue("Z♠")).toThrow(); | ||
| expect(() => getCardValue("")).toThrow(); | ||
| expect(() => getCardValue(null)).toThrow(); |
Contributor
There was a problem hiding this comment.
A string with valid rank followed by an invalid suit, and a string with a valid rank followed by two suit characters are also good test candidates.
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelist
Completed the following exercises: