London | 26-ITP-Jan | Oussama Mouggal | sprint 3 | implement-and-rewrite-tests#1026
Open
Oussama-Mouggal wants to merge 9 commits intoCodeYourFuture:mainfrom
Open
Conversation
…ts for all card types
Oussama-Mouggal
added
the
Needs Review
Oussama-Mouggal
changed the title
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Mar 3, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Very good work adding lots of test cases - especially catching edge cases.
You may want to take a closer look at some of the implementation which could be improved
Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js
Outdated
Show resolved
Hide resolved
Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js
Outdated
Show resolved
Hide resolved
LonMcGregor
added
Reviewed
Oussama-Mouggal
added
the
Needs Review
|
Thanks for making these changes |
LonMcGregor
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
I rewrited the code and tested edge cases using jest