Skip to content

London | ITP-Jan 26 | Maryanne Mosonik | Sprint 1 | Coursework#1024

Open
Maryanne-K wants to merge 22 commits intoCodeYourFuture:mainfrom
Maryanne-K:coursework/sprint-1
Open

London | ITP-Jan 26 | Maryanne Mosonik | Sprint 1 | Coursework#1024
Maryanne-K wants to merge 22 commits intoCodeYourFuture:mainfrom
Maryanne-K:coursework/sprint-1

Conversation

@Maryanne-K
Copy link

@Maryanne-K Maryanne-K commented Feb 22, 2026 •
edited
Loading

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

My PR contains all the changes made to the code/ requirements of the task. These changes have been tested.

I agree to follow the code of conduct for this organisation.

@Maryanne-K
Added detailed comment explaining the assignment operation in count u…
76db78b 
…pdate.
@Maryanne-K
Wrote code to extract initials.
92115c2
@Maryanne-K
Extracted directory and extension parts from file path
5c2bec5
@Maryanne-K
Added explanation comments for random number generation logic
1b2d588
@Maryanne-K
Added comments to clarify instructions in the first activity
fe0fccc
@Maryanne-K
Changed age variable declaration from const to let to allow reassignment
e544bc8
@Maryanne-K
Fix variable usage order to ensure cityOfBirth is defined before logging
1ff22ce
@Maryanne-K
Fixed last4Digits assignment by converting cardNumber to string befor…
2991fe1 
…e slicing
@Maryanne-K
Fixed variable names for clock time constants to follow naming conven…
d87e27e 
…tions
@Maryanne-K
Fix syntax error in priceAfterOneYear assignment and update comments …
3d0981c 
…for clarity
@Maryanne-K
Update comments for clarity and detail in time format calculations
80fd388
@Maryanne-K
Added detailed comments explaining each step of the pence to pounds c…
cba4de4 
…onversion process
@Maryanne-K
Explanations for alert and prompt functions in Chrome console instruc…
fb69f95 
…tions
@Maryanne-K
Added outputs for console methods in objects.md
db2d6dd
@github-actions

This comment has been minimized.

Sign in to view
@Maryanne-K Maryanne-K added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 22, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 22, 2026
@github-actions

This comment has been minimized.

Sign in to view
2 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@Maryanne-K Maryanne-K added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 22, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 22, 2026
@Maryanne-K Maryanne-K added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 22, 2026
cjyuan
cjyuan reviewed Mar 3, 2026
View reviewed changes
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 3, 2026
@Maryanne-K Maryanne-K added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 3, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Mar 3, 2026

Thanks for responding to each inline comment.

Can you dig deeper why .padEnd(2, "0") is optional? All the other responses are spot on.

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 3, 2026
@Maryanne-K Maryanne-K added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 4, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Mar 5, 2026

Changes are good, and explanations are spot on. Well done.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 5, 2026
@Maryanne-K Maryanne-K mentioned this pull request Mar 6, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Maryanne-K @cjyuan