London | 26-ITP-January | Damian Dunkley | Sprint 3 | Coursework/sprint3#1013
Open
DamianDL wants to merge 15 commits intoCodeYourFuture:mainfrom
Open
London | 26-ITP-January | Damian Dunkley | Sprint 3 | Coursework/sprint3#1013DamianDL wants to merge 15 commits intoCodeYourFuture:mainfrom
DamianDL wants to merge 15 commits intoCodeYourFuture:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
3 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
DamianDL
added
📅 Sprint 3
DamianDL
added
Needs Review
Edu-Vin
added
Review in progress
Edu-Vin
reviewed
Mar 4, 2026
| test(`Should return 10 when given a 10 card`, () => { | ||
| expect(getCardValue("10♠")).toEqual(10); | ||
| }); | ||
| // Face Cards (J, Q, K) |
There was a problem hiding this comment.
You didn't add jest tests for Face Cards.
Author
There was a problem hiding this comment.
Thanks for the review-Tests added for all (JQK) Face cards. Please review? Thanks Damian
|
I love the extensive test cases that were provided in the 3-get-card-value.js in the implement folder. |
Edu-Vin
added
Reviewed
DamianDL
added
Needs Review
Edu-Vin
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Changes made to Sprint 3 1-implement-and-rewrite-tests, for all three scenarios. Used Jest to run tests.
Questions