London | 26-ITP-January | Damian Dunkley | Sprint 2 | coursework/sprint-2 by DamianDL · Pull Request #1012 · CodeYourFuture/Module-Structuring-and-Testing-Data

DamianDL · 2026-02-21T15:10:43Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Completion of Sprint 2 exercises

Questions

Please review changes to exercises?

oyagbileoluwaseun

You can make the few adjustments, especially in 1-key-errors, and it would be better.

oyagbileoluwaseun · 2026-03-03T07:10:39Z

Sprint-2/1-key-errors/0.js

+// The error is occurring because we are trying to declare a variable 'str' inside the function that has the same name as the parameter 'str'.To fix this problem,  create an variable with a new name Newstr . So we would change the line to: Newstr = `${str[0].toUpperCase()}${str.slice(1)}`; 
 // =============> write your new code here
+ function capitalise(str) {
+  let Newstr = `${str[0].toUpperCase()}${str.slice(1)}`;


Hello Damian,

This is good work spotting the error, but do you know about the camelCase name convention? You can check that out to help improve your naming convention.

Hi Oyagbile- thanks for the review and feedback. New variable name changed from Newstr to newStr, to conform to camelCase naming convention. Thanks

oyagbileoluwaseun · 2026-03-03T07:21:37Z

Sprint-2/1-key-errors/1.js

 // Finally, correct the code to fix the problem
 // =============> write your new code here
+function convertToPercentage(decimalNumber) {
+  const decimalNum = 0.5;


You successfully sorted the redeclaration error.

oyagbileoluwaseun · 2026-03-03T07:23:22Z

Sprint-2/1-key-errors/2.js


 // =============> write your new code here
-
+function square(num) {


This is well done.

oyagbileoluwaseun · 2026-03-03T07:24:41Z

Sprint-2/2-mandatory-debug/0.js


 // =============> write your explanation here
-
+// The error is occurring because the function 'multiply' is not returning any value. In JavaScript, if a function does not explicitly return a value, it returns 'undefined' by default. To fix this problem, we need to add a return statement to the function that returns the result of multiplying 'a' and 'b'. For example, we could change the line to: return a * b; so that the function will return the correct result when called.


oyagbileoluwaseun · 2026-03-03T07:29:50Z

Sprint-2/2-mandatory-debug/2.js

+
 // Explain why the output is the way it is
 // =============> write your explanation here
+// The function getLastDigit is not taking any parameters, so it always returns the last digit of the global variable 'num', which is 103. The function should take a number as a parameter and return the last digit of that number.


The function will ignore the arguments passed in and always return the last digit of the global variable num.

oyagbileoluwaseun · 2026-03-03T07:33:04Z

Sprint-2/3-mandatory-implement/1-bmi.js

 function calculateBMI(weight, height) {
    // return the BMI of someone based off their weight and height
-}
+    const bmi = weight / (height ^2);


Do you think this is the most optimised way to do an exponentiation?

If not leyt me know how you would fix it.

oyagbileoluwaseun · 2026-03-03T07:39:07Z

Sprint-2/3-mandatory-implement/3-to-pounds.js

+  penceString.length - 1
+);
+
+const paddedPenceNumberString = penceStringWithoutTrailingP.padStart(3, "0");


This is good.

oyagbileoluwaseun · 2026-03-03T07:40:39Z

Sprint-2/4-mandatory-interpret/time-format.js

@@ -10,6 +10,10 @@ function formatTimeDisplay(seconds) {

  return `${pad(totalHours)}:${pad(remainingMinutes)}:${pad(remainingSeconds)}`;
 }


…tr, to conform with camelCase naming

…taking global parameter only

…t an exponent in JS to heightxheight

…t an exponent in JS to Math.pow(height,2)

oyagbileoluwaseun · 2026-03-03T21:48:53Z

Sprint-2/1-key-errors/0.js

 // =============> write your explanation here
+// The error is occurring because we are trying to declare a variable 'str' inside the function that has the same name as the parameter 'str'.To fix this problem,  create an variable with a new name Newstr . So we would change the line to: Newstr = `${str[0].toUpperCase()}${str.slice(1)}`; 
 // =============> write your new code here
+ function capitalise(str) {


oyagbileoluwaseun · 2026-03-03T21:50:53Z

Sprint-2/1-key-errors/0.js


 // =============> write your explanation here
+// The error is occurring because we are trying to declare a variable 'str' inside the function that has the same name as the parameter 'str'.To fix this problem,  create an variable with a new name Newstr . So we would change the line to: Newstr = `${str[0].toUpperCase()}${str.slice(1)}`; 
 // =============> write your new code here


This is good.

DamianDL added 2 commits February 17, 2026 11:55

changes to Sprint2 key errors and debug updated

a42a22b

Completing Sprint-2

074adf1

DamianDL added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 2 Assigned during Sprint 2 of this module Submit:PR Module-Structuring-And-Testing-Data The name of the module. and removed Submit:PR labels Feb 21, 2026

oyagbileoluwaseun self-assigned this Mar 3, 2026

oyagbileoluwaseun added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 3, 2026

oyagbileoluwaseun suggested changes Mar 3, 2026

View reviewed changes

oyagbileoluwaseun added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Mar 3, 2026

DamianDL added 4 commits March 3, 2026 11:43

Update to 1-key-errors\0.js, variable name change from Newstr to newS…

b50c220

…tr, to conform with camelCase naming

Updated the comments on line 25 to make clearer and consice.Function …

b5f1e22

…taking global parameter only

Update to mandatory-implement\1-bmi.js to change height^2 which is no…

863b7a8

…t an exponent in JS to heightxheight

Update to mandatory-implement\1-bmi.js to change height^2 which is no…

71ca135

…t an exponent in JS to Math.pow(height,2)

DamianDL added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 3, 2026

oyagbileoluwaseun added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 3, 2026

oyagbileoluwaseun approved these changes Mar 3, 2026

View reviewed changes

oyagbileoluwaseun added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Mar 3, 2026

DamianDL mentioned this pull request Mar 8, 2026

Jan 26 ITP London | Structuring and testing data | DamianDunkley DamianDL/My-Coursework-Planner#37

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

London | 26-ITP-January | Damian Dunkley | Sprint 2 | coursework/sprint-2#1012

London | 26-ITP-January | Damian Dunkley | Sprint 2 | coursework/sprint-2#1012
DamianDL wants to merge 6 commits intoCodeYourFuture:mainfrom
DamianDL:coursework/sprint-2

DamianDL commented Feb 21, 2026 •

edited

Loading

Uh oh!

oyagbileoluwaseun left a comment

Uh oh!

oyagbileoluwaseun Mar 3, 2026

Uh oh!

DamianDL Mar 3, 2026

Uh oh!

oyagbileoluwaseun Mar 3, 2026

Uh oh!

oyagbileoluwaseun Mar 3, 2026

Uh oh!

oyagbileoluwaseun Mar 3, 2026

Uh oh!

oyagbileoluwaseun Mar 3, 2026

Uh oh!

oyagbileoluwaseun Mar 3, 2026

Uh oh!

oyagbileoluwaseun Mar 3, 2026

Uh oh!

oyagbileoluwaseun Mar 3, 2026

Uh oh!

oyagbileoluwaseun Mar 3, 2026

Uh oh!

oyagbileoluwaseun Mar 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		// =============> write your new code here

		function square(num) {


		// =============> write your explanation here

		// The error is occurring because the function 'multiply' is not returning any value. In JavaScript, if a function does not explicitly return a value, it returns 'undefined' by default. To fix this problem, we need to add a return statement to the function that returns the result of multiplying 'a' and 'b'. For example, we could change the line to: return a * b; so that the function will return the correct result when called.

		@@ -10,6 +10,10 @@ function formatTimeDisplay(seconds) {

		return `${pad(totalHours)}:${pad(remainingMinutes)}:${pad(remainingSeconds)}`;
		}

Uh oh!

Conversation

DamianDL commented Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Questions

Uh oh!

oyagbileoluwaseun left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

DamianDL commented Feb 21, 2026 •

edited

Loading