Skip to content

Glasgow | Jan-26 | Elisabeth Matulian | Sprint 3 | Refactoring Dead Code #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Elisabeth-Matulian wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Glasgow | Jan-26 | Elisabeth Matulian | Sprint 3 | Refactoring Dead Code #1008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5808eb2
completed-dead-code
Elisabeth-Matulian Feb 21, 2026
dd0a7d0
removed-unused-code(redundant)
Elisabeth-Matulian Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Sprint-3/3-dead-code/exercise-1.js
View file
Open in desktop
Copy link
Copy Markdown

@hkavalikas hkavalikas Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have correctly identified a line that should be removed, but you are missing one more.

Copy link
Copy Markdown
Author

@Elisabeth-Matulian Elisabeth-Matulian Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@ let testName = "Jerry";
const greeting = "hello";

function sayHello(greeting, name) {
const greetingStr = greeting + ", " + name + "!";
return `${greeting}, ${name}!`;
console.log(greetingStr);
}

testName = "Aman";
Expand Down
4 changes: 0 additions & 4 deletions Sprint-3/3-dead-code/exercise-2.js
View file
Open in desktop
Copy link
Copy Markdown

@hkavalikas hkavalikas Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have correctly identified a line that should be removed, but you are missing one more. Can you see any properties or functions that aren't contributing to your console result of console.log(countedPetsStartingWithH); ?

Copy link
Copy Markdown
Author

@Elisabeth-Matulian Elisabeth-Matulian Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,8 @@
// The countAndCapitalisePets function should continue to work for any reasonable input it's given, and you shouldn't modify the pets variable.

const pets = ["parrot", "hamster", "horse", "dog", "hamster", "cat", "hamster"];
const capitalisedPets = pets.map((pet) => pet.toUpperCase());
const petsStartingWithH = pets.filter((pet) => pet[0] === "h");

function logPets(petsArr) {
petsArr.forEach((pet) => console.log(pet));
}

function countAndCapitalisePets(petsArr) {
const petCount = {};
Expand Down