Birmingham | 26-ITP-Jan | Tasleem Adedokun | sprint 1| Structure and Testing Data#1006
Open
tasleemadedokun wants to merge 16 commits intoCodeYourFuture:mainfrom
Open
Birmingham | 26-ITP-Jan | Tasleem Adedokun | sprint 1| Structure and Testing Data#1006tasleemadedokun wants to merge 16 commits intoCodeYourFuture:mainfrom
tasleemadedokun wants to merge 16 commits intoCodeYourFuture:mainfrom
Conversation
…e console.log results in five multiple loggings.
This comment has been minimized.
This comment has been minimized.
tasleemadedokun
added
📅 Sprint 1
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
tasleemadedokun
changed the title
tasleemadedokun
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Mar 2, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work, just a few very minor things to have another look at
Sprint-1/2-mandatory-errors/4.js
Outdated
| @@ -1,2 +1,11 @@ | |||
| const 12HourClockTime = "20:53"; | |||
| const 24hourClockTime = "08:53"; No newline at end of file | |||
| const Hour12ClockTime = "20:53"; | |||
There was a problem hiding this comment.
be careful to be consistent with naming. these variables are functional now, but do they have the same name format?
Sprint-1/1-key-exercises/4-random.js
Outdated
|
|
||
| // Math.floor usually rounds the number down to the nearest integer. | ||
|
|
||
| console.log (num); // first print is 24 |
There was a problem hiding this comment.
Do you need to have a space between the function name and the brackets?
Author
There was a problem hiding this comment.
@LonMcGregor thank you very much i have effect all changes. Thank you for time.
LonMcGregor
added
Reviewed
tasleemadedokun
added
Needs Review
|
Great work, this task is complete now |
LonMcGregor
added
Complete
Author
Thank you very much. I really appreciate. However I noticed it is failling one check, what could it be? |
|
@tasleemadedokun If you read the comment from the bot above, possibly the issue is with the title of this PR. It looks OK to me though, so I don't think you need to change anything more at this point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I have answered and done the exercises.