Glasgow | Jan-26 | Elisabeth Matulian | Sprint 3 | Coursework practice tdd#1005
Open
Elisabeth-Matulian wants to merge 6 commits intoCodeYourFuture:mainfrom
Open
Conversation
This comment has been minimized.
This comment has been minimized.
Elisabeth-Matulian
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
Elisabeth-Matulian
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
Elisabeth-Matulian
added
the
Needs Review
hkavalikas
added
Review in progress
hkavalikas
suggested changes
Mar 1, 2026
| const count = countChar(str, char); | ||
| expect(count).toEqual(5); | ||
| }); | ||
| test("No Occurrences", () => { |
There was a problem hiding this comment.
Functionality-wise, the test is correct. But it is a tiny bit misplaced in the file, and the name could be a bit more descriptive, based on other tests in this file. Can you try to update it?
Author
There was a problem hiding this comment.
the peace of code is moved, name is updated
| function repeatStr() { | ||
| return "hellohellohello"; | ||
| function repeatStr(str, count) { | ||
| if (count >= 0) {return str.repeat(count)} |
There was a problem hiding this comment.
One little thing, for readability purposes, it's worth putting return and throw on their own lines with braces.
Author
There was a problem hiding this comment.
Thanks for mentioning, I have changed the position on the line
There was a problem hiding this comment.
Functionality-wise, the tests are correct, but it's going to be hard to distinguish which one fails, given that they are all named the same. How can we improve that?
Author
There was a problem hiding this comment.
That's true! Didn't think about that. Names's updated:)
Could you please take another look when you have a moment?
hkavalikas
added
Reviewed
Elisabeth-Matulian
added
the
Needs Review
hkavalikas
added
Review in progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed Coursework practice tdd tasks
Questions
No questions