Updated as per PR comments

Author: libanj0161

Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

@@ -37,11 +37,6 @@ function getAngleType(angle) {
   else if (angle > 180 && angle < 360) {
     return "Reflex angle";
   }
-
-  // if it is 360 then it is a full rotation
-  else if (angle === 360) {
-    return "Full rotation";
-  }
   // everything greater than 360 rand less than 0 return invalid angle
   else {
     return "Invalid angle";

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -24,30 +24,33 @@
 function getCardValue(card) {
   const suits = ["♠", "♥", "♦", "♣"]; // valid card suits
 
-  const suit = card.slice(-1); // gives me the last character
-  const rank = card.slice(0, -1); // gets beginning character up to (not including) the last character
+  let suit = "";
+  let rank = card;
 
-  if (!suits.includes(suit)) {
+  if (card.length > 1) {
+    suit = card.slice(-1); // gives me the last character and saves it in the suit variable.
+    rank = card.slice(0, -1); // gets beginning character up to (not including) the last character and saves it in the rank variable.
+  }
+
+  if (suit && !suits.includes(suit)) {
     throw new Error("Error invalid card");
   }
-  // TODO: Implement this function
 
   // if card is an ace return 11
-  if (card === "A♠") {
+  if (rank === "A") {
     return 11;
   }
 
   // if card is face "J", "Q", "K"
-  else if (card === "J♣" || card === "Q♦" || card === "K♥") {
+  else if (rank === "J" || rank === "Q" || rank === "K") {
     return 10;
   }
 
   // if card is a number card and card is bigger than 2 and less than 10 ("2" to "10"), should return its numerical value
-  else if (Number(card) >= 2 && Number(card) <= 10) {
-    return Number(card);
-  } else {
-    throw new Error("Error invalid card");
+  else if (Number(rank) >= 2 && Number(rank) <= 10) {
+    return Number(rank);
   }
+  throw new Error("Error invalid card");
 }
 
 // The line below allows us to load the getCardValue function into tests in other files.

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

@@ -37,16 +37,11 @@ test(`should return "Reflex angles" when (angle > 180 && < 360)`, () => {
   expect(getAngleType(245)).toEqual("Reflex angle");
   expect(getAngleType(306)).toEqual("Reflex angle");
 });
-// Case 6: Full rotation
-test("returns full rotation for 360 degrees (angle === 360))", () => {
-  expect(getAngleType(360)).toBe("Full rotation");
-});
-// Case 7: Invalid angles
-test(`should return "Invalid angles" when (angle >360)`, () => {
+// Case 6: Invalid angles
+test(`should return "Invalid angles" when (angle is =<0 &&>=360)`, () => {
   // Test various invalid angles, including boundary cases
   expect(getAngleType(400)).toEqual("Invalid angle");
-});
-// Case 8: Invalid angles
-test(`should return "Invalid angles" when (angle <0)`, () => {
   expect(getAngleType(-7)).toBe("Invalid angle");
+  expect(getAngleType(360)).toBe("Invalid angle");
+  expect(getAngleType(0)).toBe("Invalid angle");
 });

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -11,7 +11,7 @@ test(`should return false when denominator is zero`, () => {
 
 // Case 2: Proper fractions
 // the numerator is smaller than the denominator, so the fraction is a proper fraction
-test(`should return true when |numerator| < |denominator|`, () => {
+test(`should return true when numerator < denominator`, () => {
   expect(isProperFraction(6, 7)).toEqual(true);
   expect(isProperFraction(2, 4)).toEqual(true);
 });
@@ -27,7 +27,7 @@ test("should return false when numerator is bigger than denominator", () => {
 // numerator or denominator is negative, but function compares absolute values
 test("should return correct result when numerator or denominator is negative", () => {
   expect(isProperFraction(-5, 9)).toEqual(true);
-  expect(isProperFraction(-2, 0)).toEqual(false);
+  expect(isProperFraction(7, -3)).toEqual(false);
 });
 
 // Case 5: Numerator equals denominator fraction equals 1, so it is not proper