Updated after feedback

Author: libanj0161

Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

@@ -37,7 +37,12 @@ function getAngleType(angle) {
   else if (angle > 180 && angle < 360) {
     return "Reflex angle";
   }
-  // everything greater than 360 return invalid angle
+
+  // if it is 360 then it is a full rotation
+  else if (angle === 360) {
+    return "Full rotation";
+  }
+  // everything greater than 360 rand less than 0 return invalid angle
   else {
     return "Invalid angle";
   }
@@ -61,3 +66,18 @@ function assertEquals(actualOutput, targetOutput) {
 // Example: Identify Right Angles
 const right = getAngleType(90);
 assertEquals(right, "Right angle");
+
+const acute = getAngleType(45);
+assertEquals(acute, "Acute angle");
+
+const obtuse = getAngleType(120);
+assertEquals(obtuse, "Obtuse angle");
+
+const straight = getAngleType(180);
+assertEquals(straight, "Straight angle");
+
+const reflex = getAngleType(270);
+assertEquals(reflex, "Reflex angle");
+
+const invalid = getAngleType(200);
+assertEquals(invalid, "Invalid angle");

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -22,15 +22,23 @@
 // execute the code to ensure all tests pass.
 
 function getCardValue(card) {
+  const suits = ["♠", "♥", "♦", "♣"]; // valid card suits
+
+  const suit = card.slice(-1); // gives me the last character
+  const rank = card.slice(0, -1); // gets beginning character up to (not including) the last character
+
+  if (!suits.includes(suit)) {
+    throw new Error("Error invalid card");
+  }
   // TODO: Implement this function
 
   // if card is an ace return 11
-  if (card === "A") {
+  if (card === "A♠") {
     return 11;
   }
 
   // if card is face "J", "Q", "K"
-  else if (card === "J" || card === "Q" || card === "K") {
+  else if (card === "J♣" || card === "Q♦" || card === "K♥") {
     return 10;
   }
 
@@ -56,7 +64,7 @@ function assertEquals(actualOutput, targetOutput) {
 
 // TODO: Write tests to cover all outcomes, including throwing errors for invalid cards.
 // Examples:
-assertEquals(getCardValue("9"), 9);
+assertEquals(getCardValue("9♠"), 9);
 
 // Handling invalid cards
 try {

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

@@ -37,8 +37,16 @@ test(`should return "Reflex angles" when (angle > 180 && < 360)`, () => {
   expect(getAngleType(245)).toEqual("Reflex angle");
   expect(getAngleType(306)).toEqual("Reflex angle");
 });
-// Case 6: Invalid angles
-test(`should return "Invalid angles" when (angle > 180 && < 360)`, () => {
+// Case 6: Full rotation
+test("returns full rotation for 360 degrees (angle === 360))", () => {
+  expect(getAngleType(360)).toBe("Full rotation");
+});
+// Case 7: Invalid angles
+test(`should return "Invalid angles" when (angle >360)`, () => {
   // Test various invalid angles, including boundary cases
-  expect(getAngleType(360)).toEqual("Invalid angle");
+  expect(getAngleType(400)).toEqual("Invalid angle");
+});
+// Case 8: Invalid angles
+test(`should return "Invalid angles" when (angle <0)`, () => {
+  expect(getAngleType(-7)).toBe("Invalid angle");
 });

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -4,22 +4,43 @@ const isProperFraction = require("../implement/2-is-proper-fraction");
 
 // TODO: Write tests in Jest syntax to cover all combinations of positives, negatives, zeros, and other categories.
 
-// Special case: numerator is zero
+// Special case: denominator is zero
 test(`should return false when denominator is zero`, () => {
   expect(isProperFraction(1, 0)).toEqual(false);
 });
 
-test(`for positive`, () => {
+// Case 2: Proper fractions
+// the numerator is smaller than the denominator, so the fraction is a proper fraction
+test(`should return true when |numerator| < |denominator|`, () => {
   expect(isProperFraction(6, 7)).toEqual(true);
   expect(isProperFraction(2, 4)).toEqual(true);
 });
 
-test(`should return false for improper fractions`, () => {
+// Case 3: Improper fractions
+// numerator is bigger than denominator, so the fraction is not proper
+test("should return false when numerator is bigger than denominator", () => {
   expect(isProperFraction(8, 6)).toEqual(false);
   expect(isProperFraction(4, 2)).toEqual(false);
 });
 
-test(`negative combinations`, () => {
+// Case 4: Negative numbers
+// numerator or denominator is negative, but function compares absolute values
+test("should return correct result when numerator or denominator is negative", () => {
   expect(isProperFraction(-5, 9)).toEqual(true);
   expect(isProperFraction(-2, 0)).toEqual(false);
 });
+
+// Case 5: Numerator equals denominator fraction equals 1, so it is not proper
+test("should return false when numerator is equal to denominator", () => {
+  expect(isProperFraction(6, 6)).toEqual(false);
+});
+
+// Case 6: Numerator just less than denominator fraction is slightly below 1, so it is proper
+test("should return true when numerator is just less than denominator", () => {
+  expect(isProperFraction(2, 3)).toEqual(true);
+});
+
+// Case 7: Numerator greater than denominator fraction is slightly above 1, so it is not proper
+test("should return false when numerator is greater than denominator", () => {
+  expect(isProperFraction(6, 5)).toEqual(false);
+});

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

@@ -6,7 +6,7 @@ const getCardValue = require("../implement/3-get-card-value");
 
 // Case 1: Ace (A)
 test(`Should return 11 when given an ace card`, () => {
-  expect(getCardValue("A")).toEqual(11);
+  expect(getCardValue("A♠")).toEqual(11);
 });
 
 // Suggestion: Group the remaining test data into these categories:
@@ -16,15 +16,15 @@ test(`Should return 11 when given an ace card`, () => {
 
 // Case 2: Face (J, Q, K)
 test(`Should return 10 when given an face card`, () => {
-  expect(getCardValue("J")).toEqual(10);
+  expect(getCardValue("J♣")).toEqual(10);
 });
 
 test(`Should return 10 when given an face card`, () => {
-  expect(getCardValue("Q")).toEqual(10);
+  expect(getCardValue("Q♦")).toEqual(10);
 });
 
 test(`Should return 10 when given an face card`, () => {
-  expect(getCardValue("K")).toEqual(10);
+  expect(getCardValue("K♥")).toEqual(10);
 });
 // Case 3: Number Cards (2-10)
 test(`Should return numerical value when given an number card`, () => {