Updated after PR comments

Author: libanj0161

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -27,7 +27,7 @@ function getCardValue(card) {
   let suit = "";
   let rank = card;
 
-  if (card.length > 1) {
+  if (suits.includes(card.slice(-1))) {
     suit = card.slice(-1); // gives me the last character and saves it in the suit variable.
     rank = card.slice(0, -1); // gets beginning character up to (not including) the last character and saves it in the rank variable.
   }
@@ -42,15 +42,16 @@ function getCardValue(card) {
   }
 
   // if card is face "J", "Q", "K"
-  else if (rank === "J" || rank === "Q" || rank === "K") {
+  if (rank === "J" || rank === "Q" || rank === "K") {
     return 10;
   }
 
+  const num = Number(rank);
   // if card is a number card and card is bigger than 2 and less than 10 ("2" to "10"), should return its numerical value
-  else if (Number(rank) >= 2 && Number(rank) <= 10) {
-    return Number(rank);
+  if (rank !== String(num) || num < 2 || num > 10) {
+    throw new Error("Error invalid card");
   }
-  throw new Error("Error invalid card");
+  return num;
 }
 
 // The line below allows us to load the getCardValue function into tests in other files.
@@ -67,14 +68,14 @@ function assertEquals(actualOutput, targetOutput) {
 
 // TODO: Write tests to cover all outcomes, including throwing errors for invalid cards.
 // Examples:
-assertEquals(getCardValue("9♠"), 9);
+// assertEquals(getCardValue("9♠"), 9);
 
 // Handling invalid cards
-try {
-  getCardValue("invalid");
+// try {
+//   getCardValue("invalid");
 
-  // This line will not be reached if an error is thrown as expected
-  console.error("Error was not thrown for invalid card");
-} catch (e) {}
+//   // This line will not be reached if an error is thrown as expected
+//   console.error("Error was not thrown for invalid card");
+// } catch (e) {}
 
 // What other invalid card cases can you think of?

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

@@ -38,7 +38,7 @@ test(`should return "Reflex angles" when (angle > 180 && < 360)`, () => {
   expect(getAngleType(306)).toEqual("Reflex angle");
 });
 // Case 6: Invalid angles
-test(`should return "Invalid angles" when (angle is =<0 &&>=360)`, () => {
+test(`should return "Invalid angles" when (angle is <= 0 && >= 360)`, () => {
   // Test various invalid angles, including boundary cases
   expect(getAngleType(400)).toEqual("Invalid angle");
   expect(getAngleType(-7)).toBe("Invalid angle");

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -25,10 +25,12 @@ test("should return false when numerator is bigger than denominator", () => {
 
 // Case 4: Negative numbers
 // numerator or denominator is negative, but function compares absolute values
-test("should return correct result when numerator or denominator is negative", () => {
-  expect(isProperFraction(-5, 9)).toEqual(true);
+test("should return false when |numerator| < |denominator| positive numerator and negative denominator)", () => {
   expect(isProperFraction(7, -3)).toEqual(false);
 });
+test("should return true when |numerator| < |denominator| negative numerator and positive denominator)", () => {
+  expect(isProperFraction(-5, 9)).toEqual(true);
+});
 
 // Case 5: Numerator equals denominator fraction equals 1, so it is not proper
 test("should return false when numerator is equal to denominator", () => {

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

@@ -35,6 +35,13 @@ test(`Should return error if the card string is invalid`, () => {
   expect(() => getCardValue("17")).toThrow("Error invalid card");
 });
 
+// Case 4: Hex, Decimal Numbers
+test(`Should return error if the rank is a hex input`, () => {
+  expect(() => getCardValue("0x02♠")).toThrow("Error invalid card");
+  expect(() => getCardValue("2.1♠")).toThrow("Error invalid card");
+  expect(() => getCardValue("0002♠")).toThrow("Error invalid card");
+});
+
 // To learn how to test whether a function throws an error as expected in Jest,
 // please refer to the Jest documentation:
 // https://jestjs.io/docs/expect#tothrowerror