Skip to content

Conversation

@Oussama-Mouggal
Copy link

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I completed form controls assignment using html only

@netlify
Copy link

netlify bot commented Feb 2, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit e322c83
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/69809a2c2943a8000893012a
😎 Deploy Preview https://deploy-preview-1117--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@Oussama-Mouggal Oussama-Mouggal added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 2 Assigned during Sprint 2 of this module Module-Onboarding The name of the module. and removed 📅 Sprint 2 Assigned during Sprint 2 of this module Module-Onboarding The name of the module. labels Feb 2, 2026
@jenny-alexander jenny-alexander added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 3, 2026
@jenny-alexander jenny-alexander self-requested a review February 3, 2026 05:01
@jenny-alexander
Copy link
Contributor

@Oussama-Mouggal - Your form meets a lot of the exercise requirements. However, there are few things that should be worked on:

  • Can you run your deployed site (https://deploy-preview-1117--cyf-onboarding-module.netlify.app/form-controls/) through W3 validatorhttps://validator.w3.org/? I see 2 errors that should be fixed.
  • Can you use a different tag than <h2> in your footer? <h2> in the footer signals that there is a major section in the footer but really a name is more minor information.
  • The comments from lines 56-67 can most likely be removed how that you have finished the exercise.
  • I'm able to submit the form without selecting a tshirt colour.
  • Can you find a way to make the tshirt size not automatically default to 'XS' when the page loads?

@jenny-alexander jenny-alexander added Complete Volunteer to add when work is complete and all review comments have been addressed. Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Complete Volunteer to add when work is complete and all review comments have been addressed. labels Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants