generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 412
London | JAN-26 | Divine Mankrado | Sprint 2 | Form Control #1091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
divinmank
wants to merge
33
commits into
CodeYourFuture:main
Choose a base branch
from
divinmank:sprint-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+67
−1
Open
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
c004307
I changed the header for the body
divinmank 6529e71
Finished the content for article 2 and 3
divinmank c51d6cc
Added a hash instead of a link in html
divinmank 91de83b
I added images to the background.
divinmank cd44d17
Corrected CSS
divinmank 23b9781
Corrected image address
divinmank fdfaf6d
Changed text to white
divinmank 04fa1ee
Changed text to white
divinmank 038d24e
Text change to white
divinmank baef6b3
Fixed background
divinmank bae3ed5
Created the Input fields and added a submit button.
divinmank 888b0ed
Created the Input fields and added a submit button.
divinmank eb3da85
Made another html page for the GET action and have added ids and labe…
divinmank b31f408
Added checkboxes
divinmank f56e156
Added checkbox for sizes
divinmank f76d6f4
Added placeholders for the other options
divinmank af18453
Changed attribtue type from checkbox to radio to allow for only one s…
divinmank 1ac8d59
Corrected mistake with radio types
divinmank 0037049
Fixed mistake with two inputs for one prompt
divinmank 366151a
fixed accessibility
divinmank 7b7f3f1
cleaned up email and name
divinmank e667bbd
cleaned up code
divinmank d1711be
Collaborated and updated code to get good scores on lighthouse
divinmank 73cf850
reverted code back to dummy
divinmank 75f4272
Final changes
divinmank 9cbf78a
final edit
divinmank a818f57
Reverted wireframe to original
divinmank fe591a8
adddeed space
divinmank 2d0cd5e
removed spaces
divinmank 1056972
reverted css
divinmank 2741304
extra space
divinmank be48072
removed spaces
divinmank 7de9d48
removed extra
divinmank File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <meta http-equiv="X-UA-Compatible" content="ie-edge"> | ||
| <title>Results</title> | ||
| </head> | ||
| <body> | ||
| <div id="results"></div> | ||
| <a href="/">Back to Form</a> | ||
| <script> | ||
| const resultsList = document.getElementById('results') | ||
| new URLSearchParams(window.location.search).forEach((value,name) => { | ||
| resultsList.append(`${name}: ${value}`) | ||
| resultsList.append(document.createElement('br')) | ||
| }) | ||
| </script> | ||
| </body> | ||
| </html> | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what this file does? One of the requirements is not to use javascript.
This page seems to be unrelated to the task?