London | Jan-26 | Maryanne Mosonik | Sprint 2 | Form Controls #1088
+41
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Maryanne-K
added
the
Needs Review
MorganDavid
reviewed
Jan 31, 2026
Form-Controls/index.html
Outdated
| this will also help you fill in your PR message later--> | ||
| <div> | ||
| <label>Name</label> | ||
| <input type="text" minlength="2" required> |
There was a problem hiding this comment.
The lighthouse accessibility score is only 91 on this page whereas we would like it to be 100.
Maybe you can run lighthouse on your page and see what it suggests?
Author
There was a problem hiding this comment.
@MorganDavid Kindly check accessibility score now. I think the issue was in the label and input code, which I have now corrected.
MorganDavid
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I have edited the HTML code and created a form that fulfills all the stated requirements.
I agree to follow the code of conduct for this organisation.