Manchester | ITP Jan-2026 | Ofonime Edak| Sprint 2 | Form Control #1057
Conversation
This comment has been minimized.
This comment has been minimized.
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Ofonimeedak
added
📅 Sprint 2
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
Ofonimeedak
added
the
Needs Review
cjyuan
added
Review in progress
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
-
According to https://validator.w3.org/, there are errors in your code. Can you fix them?
-
Have you tried submitting the form to ensure it behaves as expected?
- If any value is omitted, the form won't submit
- If all input are valid, then the form can be submitted successfully
-
Currently a user can enter a name consisting of only space characters (e.g., " "). Can you enforce a stricter validation rule using the
patternattribute to disallow any name that contains only space characters?
Form-Controls/index.html
Outdated
| <select name="size" id="size"> | ||
| <option value="xs">XS</option> | ||
| <option value="s">S</option> | ||
| <option value="l">L</option> | ||
| <option value="xl">XL</option> | ||
| <option value="xxl">XXL</option> | ||
| </select> |
There was a problem hiding this comment.
-
Spec asks for 6 different sizes.
-
There is a way to configure a
<select>element so that no option is selected by default, allowing the user to make an explicit choice.
There was a problem hiding this comment.
Thank you very much, Cjyuan, for your feedback. I have done the correction, but I think checking the validator is not working because the URL is not public, and the github Url contains other HTML files
cjyuan
added
Reviewed
Ofonimeedak
added
the
Needs Review
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Good job in addressing some of my comments.
However, there are still errors in your code, can you fix them?
Suggestion: Use an AI tool to help you check errors, typo, consistency, accessibility, and suggest possible improvements.
| id="name" | ||
| placeholder="Please enter your name" | ||
| required | ||
| pattern="^[A-Za-z]{2,20}$" |
There was a problem hiding this comment.
Can you explain what this pattern mean?
There was a problem hiding this comment.
This is a regular expressions pattern, it allows only alphabets both upper and lower case and a minimum of 2 characters and maximum of 20 characters.
I choose this range because I think one’s name should be not be less than 2 characters and a single name could not be more than 20.
All inputs field have a default max character of 20 unless a max attribute is specified.
cjyuan
removed
the
Needs Review
2 participants
Self checklist
Form control using HTML only, to create a form for a T-shirt vendor