London | 25-SDC-July | Mikiyas Gebremichal | Sprint 3 | Middleware exercises #34
Closed
Mikiyas-STP wants to merge 9 commits intoCodeYourFuture:mainfrom
Closed
London | 25-SDC-July | Mikiyas Gebremichal | Sprint 3 | Middleware exercises #34Mikiyas-STP wants to merge 9 commits intoCodeYourFuture:mainfrom
Mikiyas-STP wants to merge 9 commits intoCodeYourFuture:mainfrom
Conversation
Mikiyas-STP
added
📅 Sprint 3
LonMcGregor
reviewed
Oct 28, 2025
Contributor
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Looking good, though I have a suggestion of something to think about to help improve the reusability of the middleware youve written
| return res.status(400).send("Request body must be a JSON array."); | ||
| } | ||
| // check every item is a string | ||
| const allStrings = parsed.every((item) => typeof item === "string"); |
Contributor
There was a problem hiding this comment.
here you're combining json parsing and checking the input as strings. as middleware aims to allow re-use of code, what change could you make to this that would allow you to re-use these separate checks more easily?
Author
There was a problem hiding this comment.
Thankyou for raising it. To solve this issue, i have refactored jsonArrayMiddleware into reusable middlewares for parsing and validation.
Author
There was a problem hiding this comment.
@LonMcGregor let me know if i can close this PR thanks
LonMcGregor
added
Reviewed
LonMcGregor
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
this is two express app with one containing custom middleware and another containing builtin middleware
Questions
No question