WM | 25-ITP-May | Nahom Mesfin | Sprint 2 | coursework#774
WM | 25-ITP-May | Nahom Mesfin | Sprint 2 | coursework#774nahommesfin77 wants to merge 13 commits intoCodeYourFuture:mainfrom
Conversation
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Wrong number of parts separated by |s |
nahommesfin77
added
the
Needs Review
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Wrong number of parts separated by |s |
nahommesfin77
changed the title
LonMcGregor
added
Review in progress
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work on this sprint - I have a comment in just one task for you to think about
Sprint-2/debug/recipe.js
Outdated
| ingredients: | ||
| ${recipe}`); | ||
| console.log(`${recipe.title} serves ${recipe.serves} ingredients: | ||
| ${ingredient}`); |
There was a problem hiding this comment.
What happens if you run this code? Is the output easy to read? What would you expect a recipe output to be like?
There was a problem hiding this comment.
I had misunderstood the instructions. It only requred the ingredients to be each line and not the whole console.log(`${recipe.title} serves ${recipe.serves} ingredients:. I have fixed it now and it logs:
bruschetta serves 2 ingredients:
olive oil
tomatoes
salt
pepper
LonMcGregor
added
Needs Review
|
Great - that looks much better. You can close this PR now, you are done |
LonMcGregor
added
Complete
3 participants
Learners, PR Template
Self checklist
Changelist
I debugged and fixed issues across the provided files, verifying predictions with node. Implemented new functions (contains, lookup, tally, querystring) based on requirements and tested against multiple inputs. Interpreted larger programs by researching unfamiliar syntax and used console logging to validate behaviour.