London | 25-ITP-May | Halimatou Saddiyaa | Sprint 3 | Todo list by Halimatou-saddiyaa · Pull Request #765 · CodeYourFuture/Module-Data-Groups

Halimatou-saddiyaa · 2025-08-13T17:37:40Z

Learners, PR Template

Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

Changelist

I've implemented the Todo list app with the following requirements:

display the initial list of todos
each todo has a delete and tick icon
can add a new todo to the list
can strike through a todo when it is completed
can undo a strikethrough on a todo
can delete a todo from the list
can remove all completed todos

Please review my PR.

Questions

Ask any questions you have for your reviewer.

…odos functions

sambabib · 2025-08-14T19:41:33Z

Sprint-3/todo-list/index.html

+          />
+        </div>
+        <div>
+          <button type="submit" class="btn btn-primary mt-2">Add Todo</button>


small design tip: if you have two buttons side by side (especially buttons with different functions), make sure to distinguish them by colour.

Thanks for the suggestion. I've changed the color of one of the button.

sambabib · 2025-08-14T23:31:40Z

Sprint-3/todo-list/script.js

+    return;
+  }
+
+  if (newTask !== "") {


solid implementation. side note: when you run checks like this, you should also run a check for the opposite scenario. for example, when newTask is empty, the add todo button should give feedback that the input field is empty but I understand this is outside the scope of this assignment. it is just something for you to note moving forward.

Thanks, I'll keep it in mind for my next projects.

you can give it a try right now. when the button is clicked but the input field is empty, display a simple message telling the user to write something.

you are almost there.

I’ve added a message that alerts the user if they try to submit an empty input field.

sambabib · 2025-08-14T23:40:50Z

Sprint-3/todo-list/script.js

+    trashIcon.setAttribute("aria-hidden", "true");
+    trashIcon.addEventListener("click", () => {
+      const index = todos.indexOf(todo);
+      if (index > -1) {


this is an okay solution but there is a better way to do this. have you explored other array methods?

I've replaced this by an array filtering method inside a function

better solution. well done!

sambabib · 2025-08-14T23:47:18Z

Sprint-3/todo-list/script.js

@@ -1,25 +1,73 @@
 function populateTodoList(todos) {


this function handles both data updates and UI changes, it works fine for a small task like this but when you work on much larger projects, you want to be able to reuse certain functions. in that case, keeping your code as modular as possible is the recommended approach.

I've refactored my code to create other functions to handle data updates and UI changes

Halimatou-saddiyaa · 2025-08-15T16:03:41Z

Thank you for reviewing my PR @sambabib
I've made the necessary changes, can you please check again?

sambabib · 2025-08-15T17:56:21Z

Sprint-3/todo-list/script.js

+  todo.completed = !todo.completed;
+}
+
+function removeTodo(todos, todo) {


very good. it's much cleaner and reusable.

Halimatou-saddiyaa · 2025-08-16T14:07:40Z

@sambabib I've changed my code to implement the suggested corrections.
Can you please check again?

sambabib · 2025-08-18T22:24:04Z

Sprint-3/todo-list/script.js

  let input = document.getElementById("todoInput");
  let newTask = input.value.trim();

+  if (newTask === "") {


good job handling this edge case. well done!

Halimatou-saddiyaa added 3 commits August 13, 2025 19:14

Implemented the populateTodoList, addNewTodo, and deleteAllCompletedT…

63e615a

…odos functions

Implemented changes to html to build the to do list

70fd623

Added some styling to the Css file

4bb42f0

Halimatou-saddiyaa added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 13, 2025

sambabib added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 14, 2025

sambabib reviewed Aug 14, 2025

View reviewed changes

sambabib added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Aug 15, 2025

Halimatou-saddiyaa added 2 commits August 15, 2025 17:43

Added a different color for the 'remove all-completed' button

9588977

Separated data updates and UI changes

32858f9

Halimatou-saddiyaa added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 15, 2025

sambabib reviewed Aug 15, 2025

View reviewed changes

sambabib added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 15, 2025

Changed the code to add a 'empty field alert'

f96d991

Halimatou-saddiyaa added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 16, 2025

sambabib reviewed Aug 18, 2025

View reviewed changes

sambabib added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 18, 2025

illicitonion closed this Sep 1, 2025

Uh oh!

Conversation

Halimatou-saddiyaa commented Aug 13, 2025

Learners, PR Template

Changelist

Questions

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Halimatou-saddiyaa commented Aug 15, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Halimatou-saddiyaa commented Aug 16, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants