Fix: make job consistent with wordpress environment#12
Open
Anas-hameed wants to merge 4 commits intoCodeWithEmad:masterfrom
Open
Fix: make job consistent with wordpress environment#12Anas-hameed wants to merge 4 commits intoCodeWithEmad:masterfrom
Anas-hameed wants to merge 4 commits intoCodeWithEmad:masterfrom
Conversation
Add environment variable for db connection during init task make volume path consistent with wordpress container
We do this as wordpress would copy everything from the /usr/src/wordpress to /var/www/html on startup when it would not find a valid wordpress installation in that directory. This is also helpful when we need to install plugins during the initialization tasks as we more than often need to keep a persistent wp-config.php file.
Owner
|
Hey @Anas-hameed. Nice catch. I didn't notice the warning. |
Author
|
Yes, let me take that up as well. |
Author
|
@CodeWithEmad, I have updated the PR with the k8s configs as well now. |
Author
|
@CodeWithEmad, any update on this? Can you review now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The initialization task did not have the necessary environment variables to make DB connections. This is handy and required when installing certain plugins during initialization.
For now, we only had the wp-content directory mounted into the container. For this reason, wordpress would copy the installation files to
var/www/htmlon startup. For reference, here are the startup logs:By mounting the entire wordpress directory in the
var/www/htmldirectory, we can also install wordpress plugins using initialization tasks and modify the wp-config.php file during initialization tasks to keep it persistent across the job and the wordpress container itself.