Switch from errors to alerts so oauth-related flashes will show #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Line is too long. [309/80]
Unnecessary spacing detected.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Member
Author
|
This fix is related to #288. The existing error messages have information about needing a public email address on GitHub, but they are not showing up to users because they're not flashed appropriately. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors weren't showing before, which kept users from seeing helpful information about having a public email address on GitHub and valuable feedback that their login attempt has occurred.
I can't screenshot this change because I don't have a GitHub account that replicates the login error, but testing flashes in the dashboard verified that
flash[:error]does not show a result, whileflash[:alert]shows up in red at the top of the page.The other option was to add
flash[:error]to the application layout, but it doesn't have the styling that alerts do, so this seemed like the better option.