-
Notifications
You must be signed in to change notification settings - Fork 72
Github link validation - prep for user input #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😋!
|
Using the url get_github_details('https://github.com/CodeMontageHQ/codemontage/pull/269')
=> {:github_org=>"CodeMontageHQ/codemontage/pull", :github_repo=>"269"} |
|
Nice example, @acrogenesis! Thank you. |
|
Thanks for the heads up, @acrogenesis! I've added some commits that (a) add your example to our existing specs & (b) account for word chars & dashes instead of any non-whitespace character (which was clearly far too broad). The regex is ugly but (currently, maybe, fingers-crossed) gets the job done. |
|
Simpler, cuter solution at #286. |
This code prepares to allow users to input a github link when adding new projects to the platform.