fix: changed donate button link to direct to balancer github page#465
Open
amahuli03 wants to merge 1 commit intoCodeForPhilly:developfrom
Open
fix: changed donate button link to direct to balancer github page#465amahuli03 wants to merge 1 commit intoCodeForPhilly:developfrom
amahuli03 wants to merge 1 commit intoCodeForPhilly:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated the 4 donate buttons to direct to the Balancer GitHub repo instead of the old donation site.
Let me know if this is wrong or if I've misunderstood the issue.
Related Issue
Closes #445
Manual Tests
Ran app locally, verified all
donatebuttons redirect to the right place.Automated Tests
N/A, just a static URL change
Documentation
No documentation updates needed.
Reviewers
@sahilds1
Notes
The donation site link was hardcoded in 4 separate places. It may be worth extracting them into a shared constant to make updates like this simpler in the future.