Find Method Picker #322
Merged
Find Method Picker #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd. Options include: contains, match word, starts with, ends with, and regular expression.
thecoolwinter
requested changes
May 29, 2025
Collaborator
thecoolwinter
left a comment
thecoolwinter
left a comment
There was a problem hiding this comment.
Found a crash while messing around, we should probably fix the crash itself in CETV but it should be fixed here too.
Sources/CodeEditSourceEditor/Find/ViewModel/FindPanelViewModel+Find.swift
Outdated
Show resolved
Hide resolved
Sources/CodeEditSourceEditor/Find/ViewModel/FindPanelViewModel+Find.swift
Outdated
Show resolved
Hide resolved
Sources/CodeEditSourceEditor/Find/ViewModel/FindPanelViewModel+Find.swift
Outdated
Show resolved
Hide resolved
Collaborator
|
It's concerning that we don't have any tests for the find panel besides the height changes. |
Co-authored-by: Khan Winter <35942988+thecoolwinter@users.noreply.github.com>
Collaborator
Author
|
Fixed the tests, we should be good to go! ✅ |
austincondiff
requested review from
0xWDG,
FastestMolasses,
thecoolwinter and
tom-ludwig
thecoolwinter
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added find method picker that changes the method by which text is found. Options include:
Related Issues
Checklist
Screenshots
Screen.Recording.2025-05-28.at.4.07.59.PM.mov