mctp-estack: fix MCTP serial parsing and framing with escape sequences#45
Closed
mark64 wants to merge 1 commit intoCodeConstruct:mainfrom
Closed
mctp-estack: fix MCTP serial parsing and framing with escape sequences#45mark64 wants to merge 1 commit intoCodeConstruct:mainfrom
mark64 wants to merge 1 commit intoCodeConstruct:mainfrom
Conversation
mark64
changed the title
Signed-off-by: Mark Hill <markleehill@gmail.com>
Author
|
The CI failures appear unrelated to this change, but if required I can fix them |
Author
|
nevermind, linux does it the way it is in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if an MCTP serial packet had an escape sequence in the frame checksum, it would fail to parse in mctp-rs.
The DMTF spec, however, requires that escaping be performed after FCS generation on transmit, and similarly that
escaping be performed before FCS checking on receive, so the current behavior is incorrect.
I fixed the serial.rs code and added some unit tests to cover these cases.