Skip to content

Fix initial PDF page count showing 1 of 0 #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rithish-2914 wants to merge 2 commits into
base: staging
Choose a base branch
from
+23 −5
Open

Fix initial PDF page count showing 1 of 0 #505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba17c7e
Fix PDF viewer initial page count bug
Rithish-2914 May 8, 2026
ddd47c9
Resolve merge conflicts
Rithish-2914 May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added FETCH_HEAD
View file
Open in desktop
Empty file.
13 changes: 8 additions & 5 deletions src/components/newPdfViewer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,14 @@ const Controls = memo(function Controls({documentId, toggleFullscreen, isFullscr

useEffect(() => {
if (!scrollProv) return;
const unsub = scrollProv.onPageChange(() =>
setPageNo(String(scrollProv.getCurrentPage()))
);
const unsub = scrollProv.onPageChange(() => {
const current = scrollProv.getCurrentPage();
setPageNo(String(current));
});
const current = scrollProv.getCurrentPage();
setPageNo(String(current));
return () => unsub();
}, [scrollProv]);
}, [scrollProv, scrollState?.totalPages]);

const pageChange = useCallback(
(e: React.KeyboardEvent<HTMLInputElement>) => {
Expand Down Expand Up @@ -105,7 +108,7 @@ const Controls = memo(function Controls({documentId, toggleFullscreen, isFullscr
onFocus={() => setPageNo("")}
className="h-9 w-14 rounded border bg-[#e7e9ff] p-1 text-center text-sm [appearance:textfield] dark:bg-[#1f1f2a] [&::-webkit-inner-spin-button]:appearance-none [&::-webkit-outer-spin-button]:appearance-none"
/>
<span className="text-xs font-medium text-white">of {totalPages ?? 1}</span>
<span className="text-xs font-medium text-white">of {totalPages ?? "..."}</span>
</div>
)

Expand Down
15 changes: 15 additions & 0 deletions taginggit pull origin staginggit pull origin staging
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
feat/paper-preview-modal
fix/accordion-toggle
* fix/pdf-viewer-page-count
staging
remotes/origin/HEAD -> origin/staging
remotes/origin/feat/paper-preview-modal
remotes/origin/fix/accordion-toggle
remotes/origin/fix/pdf-viewer-page-count
remotes/origin/staging
remotes/upstream/HEAD -> upstream/staging
remotes/upstream/dependabot/npm_and_yarn/axios-1.13.5
remotes/upstream/dependabot/npm_and_yarn/lodash-4.17.23
remotes/upstream/dependabot/npm_and_yarn/next-15.5.10
remotes/upstream/prod
remotes/upstream/staging
Loading