feat(achievements): add cute, accessible inline SVG icons that adapt to light/dark#46
Open
Gourangi4 wants to merge 1 commit intoCode-Social:mainfrom
Open
feat(achievements): add cute, accessible inline SVG icons that adapt to light/dark#46Gourangi4 wants to merge 1 commit intoCode-Social:mainfrom
Gourangi4 wants to merge 1 commit intoCode-Social:mainfrom
Conversation
…re via currentColor; accessible (aria-hidden, not focusable) (Code-Social#23)
9503ce8 to
143d112
Compare
Contributor
Author
|
Hey, @Rizwan102003 ,i have resolved this issue can you please check? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds consistent, theme-aware icons to Achievements (First Challenge, Design Master, Code Warrior, Community Helper, Streak Master). Icons are inline SVGs that inherit
currentColor, so they automatically work in light & dark themes. (Optional: also adds a minimal icon for All Rounder.)Why
What changed
BadgeIconcomponent (badge key → inline SVG).fill="none",stroke="currentColor",aria-hidden,focusable={false}.Accessibility
Testing
Closes #23.
