fix: logout button not working in sidebar#1368
fix: logout button not working in sidebar#1368Avdhesh-Varshney merged 2 commits intoCode-A2Z:mainfrom
Conversation
|
@pratyushjha06 is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE. |
| setShowExpandedView(false); | ||
| }, []); | ||
|
|
||
| const onLogout = useCallback(() => { |
There was a problem hiding this comment.
No need to write a separate function for logout.
Just pass the logout to onClick parameter.
There was a problem hiding this comment.
Revert the changes of this file. These are not required.
There was a problem hiding this comment.
Revert the changes of this file. These are not required.
Done
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Avdhesh-Varshney
left a comment
Avdhesh-Varshney
left a comment
There was a problem hiding this comment.
Hey @pratyushjha06, Why have you added new lines in file? (This breaks formatting)
Great work. PR Approved 🎉
2 participants
Pull Requests Review Criteria
Caution
PRs that fail to meet these review standards will be automatically flagged and may be rejected by maintainers.
mainCloses: #1357
Describe the add-ons or changes you've made 📃
onLogoutfunction inuseSidebarhookuseAuthhook for proper state managementhandleClicklogic inSidebarMenuItemto checkonClickfirst beforepath/loginafter logoutChanges
shared/components/organisms/sidebar/hooks/index.ts- Added onLogout using useAuthshared/components/organisms/sidebar/components/SidebarMenuItem.tsx- Fixed onClickScreenshots 📷
16-41-00.-.Trim.mp4
Note to reviewers (Optional) 📄