Adding basic CICD, commenting out old CICD, disabling nx cloud#111
Open
SamNie2027 wants to merge 4 commits intomainfrom
Open
Adding basic CICD, commenting out old CICD, disabling nx cloud#111SamNie2027 wants to merge 4 commits intomainfrom
SamNie2027 wants to merge 4 commits intomainfrom
Conversation
maxn990
approved these changes
Feb 3, 2026
Member
maxn990
left a comment
There was a problem hiding this comment.
approved with a few comments, overall looks really good! maybe we could add some sort of workflows.md file too just to clarify the structure for new tls and also explain why some parts are commented out.
thanks for taking this on, it's much appreciated!
thaninbew
requested changes
Feb 3, 2026
thaninbew
left a comment
There was a problem hiding this comment.
Overall looks good! I also disabled Nx cloud in the FCC repo.
my review from looking at your file changes:
Agreed with Max's points:
- adding clarity to documentation will be best, especially if scaffolding's gonna continue to be the norm for new C4C projects. "make it clear (in comments) that this is an example workflow for deployment"
- I also think that we should keep nx affected if there wasn't any specific reason for removing it, since our projects can get large and linter can get slow.
Additional:
- workflow files, (i.e.
backend_build.ymland others..) should have trailing newlines at the end (I also lowkey forget, but it's best practice) - added a comment on the
lint.ymlfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
CICD from BHCHP that builds frontend using
npx nx build frontendandnpx nx build backendand uses yarn to install and run dependencies.Disables NX cloud so that GitHub Actions workloads don't become limitted.
Frontend build, backend build, linter, and test run are all separate so that there can be clear specificity from the PR page of what failed.
Comments out old CICD, saving it if a team has fully build-out cloud infrastructure for frontend/ backend using app runner and amplify. This CICD is more suitable for projects because it runs everything locally as it would be run locally.
✔️ Verification
Works on the BHCHP repo.