Skip to content

179 refactor application applicant#193

Merged
SamNie2027 merged 5 commits intomainfrom
179-refactor-application-applicant
Mar 18, 2026
Merged

179 refactor application applicant#193
SamNie2027 merged 5 commits intomainfrom
179-refactor-application-applicant

Conversation

@anjalisilina
Copy link
Copy Markdown

ℹ️ Issue

Closes #179

📝 Description

Briefly list the changes made to the code:

  1. Moved startDate and endDate fields to Application from Applicant and refactored corresponding tests, endpoints and Application files
  2. Changed Applicant to CandidateInfo and refactored files
  3. Changed Admin to AdminInfo and refactored files
  4. Made email the primary key for both CandidateInfo and AdminInfo
  5. Deleted firstName and lastName fields for both CandidateInfo and AdminInfo

✔️ Verification

Ran and passed updated tests:
Screenshot 2026-03-03 at 6 50 45 PM

New directories:
Screenshot 2026-03-03 at 6 48 43 PM
Screenshot 2026-03-03 at 6 51 11 PM

🏕️ (Optional) Future Work / Notes

Might be other places to refactor these changes including migrations

Copy link
Copy Markdown
Collaborator

@SamNie2027 SamNie2027 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual endpoints and data structure are still called applicant - can you fix that to be candidate? Otherwise looks good, although there are merge conflicts to resolve as well.

@SamNie2027 SamNie2027 merged commit 021c49d into main Mar 18, 2026
4 checks passed
@SamNie2027 SamNie2027 deleted the 179-refactor-application-applicant branch March 18, 2026 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor Applicant-> Candidate and Admin

3 participants