Skip to content

200 project card#207

Open
mehanana wants to merge 10 commits into
mainfrom
200-project-card
Open

200 project card#207
mehanana wants to merge 10 commits into
mainfrom
200-project-card

Conversation

@mehanana

@mehanana mehanana commented May 12, 2026

Copy link
Copy Markdown
Contributor

ℹ️ Issue

#200

📝 Description

Created project card components for both active and archived project cards

Briefly list the changes made to the code:

  1. Created separate files for the active project card and archived project card components
  2. Created tests to ensure the right elements were appearing
  3. Tested on local host to make sure it matched figma designs

✔️ Verification

What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.

Provide screenshots of any new components, styling changes, or pages.
Screenshot 2026-05-12 004201
image

🏕️ (Optional) Future Work / Notes

Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!

@mehanana mehanana requested a review from nourshoreibah as a code owner May 12, 2026 13:45
@github-actions github-actions Bot requested a review from tsudhakar87 May 12, 2026 13:45
github-actions Bot added a commit that referenced this pull request May 12, 2026

@tsudhakar87 tsudhakar87 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks solid! just some minor things I noticed when testing locally

Comment thread apps/frontend/src/app/components/ArchiveProjectCard.tsx Outdated
Comment thread apps/frontend/src/app/components/ActiveProjectCard.tsx Outdated
Comment thread apps/frontend/src/app/components/ActiveProjectCard.tsx Outdated

@nourshoreibah nourshoreibah left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Echoing thillai's comments and also, thoughts on making this one component with a prop for whether it's archived or not? Or alternatively extracting out the shared portions (maybe just the top right corner Staff section)? Just want to make sure we don't have to maintain things in 2 places

Otherwise looks great!

Comment thread apps/frontend/src/app/components/ArchiveProjectCard.tsx Outdated

@tsudhakar87 tsudhakar87 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks solid! just a minor nit and maybe some outdated changes

Comment thread apps/frontend/src/app/components/ProjectCard.tsx Outdated
Comment thread apps/frontend/src/app/components/ProjectCard.tsx Outdated
Comment thread apps/frontend/src/app/components/ProjectCard.tsx Outdated
Comment thread apps/frontend/src/app/page.tsx Outdated
Comment thread apps/frontend/src/app/components/ArchiveProjectCard.tsx Outdated

@tsudhakar87 tsudhakar87 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for bearing with all the nits!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants