Skip to content

Conversation

@0utplay
Copy link
Member

@0utplay 0utplay commented Jan 19, 2026

Motivation

Having the wrapper as java agent instead of a standalone application that boots the regular application resolves issues where e.g. the application depends on SPI to get some implementation, which was not possible with the current wrapper setup.

Modification

Re-designed the wrapper to be a java agent that is attached instead of a standalone application

Result

The wrapper is an agent and we can start taking a look into sponge support again

@0utplay 0utplay requested a review from derklaro January 19, 2026 15:44
@0utplay 0utplay self-assigned this Jan 19, 2026
@0utplay 0utplay added v: 4.X This pull should be included in the 4.0 release in: node An issue/pull request releated to the node module code t: improvement The pull request improves existing code in: wrapper An issue/pull request releated to the wrapper module code labels Jan 19, 2026
@github-actions
Copy link

Test Results

 56 files  ±0   56 suites  ±0   3m 58s ⏱️ ±0s
571 tests ±0  571 ✅ ±0  0 💤 ±0  0 ❌ ±0 
938 runs  ±0  938 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f035820. ± Comparison against base commit 6043b0d.

This pull request removes 32 and adds 32 tests. Note that renamed tests count towards both.
eu.cloudnetservice.driver.impl.document.DocumentSerialisationTest ‑ [4] {"b":1,"s":2,"i":3,"l":4,"f":5.0,"d":6.0,"c":"/","string":"Hello, World!","bol":true,"cloud":["Ben?","Yes","No","HoHoHoHo"],"world":{"insane":"!","hello":"world","this":"is"}}, PRETTY
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [14] 2026-01-11
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [23] 19:46:15.214994390
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [28] 19:46:15.215111549Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [29] 19:46:15.215133370Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [30] 19:46:15.215170981+05:00
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [31] 19:46:15.215208642-03:00
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [34] 2026-01-11T19:46:15.215390593
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [39] 2026-01-11T19:46:15.215540605Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [4] 2026-01-11T19:46:15.205471872Z
…
eu.cloudnetservice.driver.impl.document.DocumentSerialisationTest ‑ [4] {"b":1,"s":2,"i":3,"l":4,"f":5.0,"d":6.0,"c":"/","string":"Hello, World!","bol":true,"cloud":["Ben?","Yes","No","HoHoHoHo"],"world":{"this":"is","insane":"!","hello":"world"}}, PRETTY
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [14] 2026-01-19
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [23] 15:47:15.106914599
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [28] 15:47:15.107023492Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [29] 15:47:15.107042858Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [30] 15:47:15.107084832+05:00
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [31] 15:47:15.107120526-03:00
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [34] 2026-01-19T15:47:15.107351293
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [39] 2026-01-19T15:47:15.141346874Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [4] 2026-01-19T15:47:15.095540342Z
…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: node An issue/pull request releated to the node module code in: wrapper An issue/pull request releated to the wrapper module code t: improvement The pull request improves existing code v: 4.X This pull should be included in the 4.0 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants